Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI CI to use Orb #1288

Merged
merged 9 commits into from
Jan 13, 2022
Merged

Update CircleCI CI to use Orb #1288

merged 9 commits into from
Jan 13, 2022

Conversation

mathomp4
Copy link
Member

Description

This PR updates the CircleCI configuration to use a new Orb that contains all the common commands, scripts, executors, etc. For more info, the repository is here:

https://github.com/GEOS-ESM/circleci-tools

and the orb is here:

https://circleci.com/developer/orbs/orb/geos-esm/circleci-tools

Related Issue

Motivation and Context

Hopefully can "cleanup" the GEOS CI a bit and reduce a lot of duplicated code. Most of the CI in GEOS have the same commands over and over. The same executors, etc. This way, I could maybe just update a version number and, bam, things are changed.

I'm using MAPL as the guinea pig.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Jan 10, 2022
@mathomp4 mathomp4 self-assigned this Jan 10, 2022
@mathomp4
Copy link
Member Author

This seems to be working. Huh.

@mathomp4 mathomp4 mentioned this pull request Jan 12, 2022
7 tasks
@mathomp4 mathomp4 marked this pull request as ready for review January 13, 2022 15:19
@mathomp4 mathomp4 requested a review from a team as a code owner January 13, 2022 15:19
@mathomp4 mathomp4 requested a review from a team as a code owner January 13, 2022 15:55
@mathomp4 mathomp4 merged commit b9577d3 into develop Jan 13, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/use-orb-ci branch January 13, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants