Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VarRead 2D_R8 interface to match VarRead 2D_R4 #1258

Merged
merged 5 commits into from
Jan 4, 2022
Merged

Update VarRead 2D_R8 interface to match VarRead 2D_R4 #1258

merged 5 commits into from
Jan 4, 2022

Conversation

bena-nasa
Copy link
Collaborator

@bena-nasa bena-nasa commented Jan 3, 2022 •
edited by pchakraborty
Loading

When the CTM was updated to use the latest version of the GEOSgcm libraries the build failed as that builds fv3 with interp_restart.x because it was calling into VarREAD_2D_R8 in NCIO due to some changes in that code (the GEOSgcm fixture uses the R4 version).

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa added 🎁 New Feature This is a new feature 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jan 3, 2022
@bena-nasa bena-nasa requested a review from a team as a code owner January 3, 2022 19:34
@bena-nasa bena-nasa changed the base branch from main to develop January 3, 2022 19:35
@bena-nasa bena-nasa mentioned this pull request Jan 3, 2022
Closed
@mathomp4 mathomp4 mentioned this pull request Jan 3, 2022
Merged
@bena-nasa bena-nasa merged commit d827865 into develop Jan 4, 2022
@bena-nasa bena-nasa deleted the feature/bmauer/ncread_2d_r8_interface branch January 4, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

Assignees
No one assigned
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bena-nasa @mathomp4