Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert fix in 2.8.7 #1075

Merged
merged 3 commits into from
Oct 13, 2021
Merged

Revert fix in 2.8.7 #1075

merged 3 commits into from
Oct 13, 2021

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Oct 13, 2021 •
edited
Loading

Description

PR #1069 incorrectly fixed #1064 causing the issue seen in #1074. This PR reverts the change to the History Grid Comp.

Reverted with:

git revert 606b7146510b794bd3a5c822543e76413130cd23

and then some changes to up the version, etc.

Related Issue

#1064, #1074

Motivation and Context

Reverts MAPL back to its correct status.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4
Revert "Fixes #1064. This bug has been in MAPL for a long time (class…
672c09b 
…ical "fence-post" problem). Once the new segment alarm rings, the new file should be open only after the current time step is written."

This reverts commit 606b714.
@mathomp4
Revert to 2.8.6
fed0c58
@mathomp4 mathomp4 added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs bugfix labels Oct 13, 2021
@mathomp4 mathomp4 self-assigned this Oct 13, 2021
@mathomp4 mathomp4 requested review from a team as code owners October 13, 2021 12:48
@mathomp4
Copy link
Member Author

Blocking until I can test this branch to make sure I did the revert right.

@mathomp4 mathomp4 removed the 🚫 Contingent - DNA Do Not Approve (DNA). These changes are contingent on other PRs label Oct 13, 2021
@mathomp4
Copy link
Member Author

Confirmed zero-diff to "stock" GEOSgcm. Restarts and History at C48 1day.

@mathomp4 mathomp4 merged commit 136821e into main Oct 13, 2021
@mathomp4 mathomp4 deleted the hotfix/mathomp4/revert-2.8.7 branch October 13, 2021 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bena-nasa bena-nasa bena-nasa approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect file timestamp with 24-hour duration and 1-hour frequency time-average
2 participants
@mathomp4 @bena-nasa