Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1064. This bug has been in MAPL for a long time (classical "fe… #1069

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Fixes #1064. This bug has been in MAPL for a long time (classical "fe… #1069

merged 1 commit into from
Oct 12, 2021

Conversation

atrayano
Copy link
Contributor

…nce-post" problem). Once the new segment alarm rings, the new file should be open only after the current time step is written.

Description

Fixes very embarrassing bug: moved the new segment action after the current step is written

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • [ x] I have tested this change with a run of GEOSgcm (if non-trivial)
  • [ x] I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • [x ] I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@atrayano
Fixes #1064. This bug has been in MAPL for a long time (classical "fe…
606b714 
…nce-post" problem). Once the new segment alarm rings, the new file should be open only after the current time step is written.
@atrayano atrayano added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. bugfix labels Oct 11, 2021
@atrayano atrayano requested review from tclune and bena-nasa October 11, 2021 21:42
@atrayano atrayano self-assigned this Oct 11, 2021
@atrayano atrayano requested a review from a team as a code owner October 11, 2021 21:42
@tclune tclune merged commit ac39ab5 into main Oct 12, 2021
@tclune tclune deleted the hotfix/atrayano/#1064_incorrect_file_timestamp branch October 12, 2021 12:30
This was referenced Oct 13, 2021
Closed
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

@bena-nasa bena-nasa Awaiting requested review from bena-nasa

Assignees

@atrayano atrayano

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atrayano @tclune