Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User found issues with Vector handling in ExtData2G #3255

Closed
bena-nasa opened this issue Dec 18, 2024 · 1 comment · Fixed by #3256
Closed

User found issues with Vector handling in ExtData2G #3255

bena-nasa opened this issue Dec 18, 2024 · 1 comment · Fixed by #3256
Assignees
@bena-nasa
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!

Comments

@bena-nasa
Copy link
Collaborator

bena-nasa commented Dec 18, 2024 •
edited
Loading

User @zhaobin74 found 2 issues with vector handling in ExtData. Just making an issue here to reference in the PR, both were easy to fix or change so just for the PR

  1. Turns using multiple rules with vectors was just broken @zhaobin74 was the first to try this, but I've found the issue and know fix.
  2. @zhaobin74 would like us to relax the restriction that vector regridding can only be bilinear. I have no beef in this so easy enough to remove the line preventing if it is what the customer wants.
@bena-nasa bena-nasa added 🪲 Bugfix This fixes a bug! 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. labels Dec 18, 2024
@bena-nasa bena-nasa self-assigned this Dec 18, 2024
@bena-nasa bena-nasa mentioned this issue Dec 18, 2024
Merged
7 tasks
mathomp4 added a commit that referenced this issue Dec 19, 2024
@mathomp4
Merge pull request #3256 from GEOS-ESM/hotfix/bmauer/fixes-#3255
1c55973 
fixes #3255
@tclune
Copy link
Collaborator

tclune commented Dec 19, 2024

What other regrid method is desired here? Hard to imagine that conservative is correct in the vector case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bena-nasa bena-nasa

Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🪲 Bugfix This fixes a bug!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #3255 GEOS-ESM/MAPL
2 participants
@tclune @bena-nasa