Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve macro for _UNUSED_DUMMY #2373

Closed
tclune opened this issue Sep 24, 2023 · 0 comments
Closed

Improve macro for _UNUSED_DUMMY #2373

tclune opened this issue Sep 24, 2023 · 0 comments
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🛠️ Refactor This is code refactoring

Comments

@tclune
Copy link
Collaborator

tclune commented Sep 24, 2023

The existing macro uses a PRINT statement and thus cannot go in PURE procedures. A suggestion by @everythingfunctional is that an ASSOCIATE block can be used instead. (Of course some care must then go to choosing a selector that does not conflict with the dummy argument.)
@tclune tclune added 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🛠️ Refactor This is code refactoring labels Sep 24, 2023
tclune added a commit that referenced this issue Sep 24, 2023
@tclune
Fixes #2373 - improved unused dummy macro
1cad971
mathomp4 added a commit that referenced this issue Sep 25, 2023
@mathomp4
Merge pull request #2374 from GEOS-ESM/feature/tclune/#2373-improve-u…
a0d1332 
…ndefined-dummy

Fixes #2373 - improved unused dummy macro
@github-actions github-actions bot mentioned this issue Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) 🛠️ Refactor This is code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mathomp4 @tclune