Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many _ASSERT(.false.) in MAPL #1378

Closed
mathomp4 opened this issue Feb 17, 2022 · 2 comments
Closed

Many _ASSERT(.false.) in MAPL #1378

mathomp4 opened this issue Feb 17, 2022 · 2 comments
Assignees
Labels
🛠️ Refactor This is code refactoring ⌛ Long Term Long term issues

Comments

@mathomp4
Copy link
Member

mathomp4 commented Feb 17, 2022

Per @tclune:

Side note: any _ASSERT(.false.,) should generally be written as _FAIL(). This should only arise when a failing conditional requires a few other actions prior to throwing the exception.

So, I decided to look at MAPL and if one greps for _ASSERT(.false.) and, well:

Tests/ExtDataDriverGridComp.F90:       _ASSERT(.false.,'needs informative message')
Tests/ExtDataRoot_GridComp.F90:               _ASSERT(.false.,'found difference when compare state')
base/Base/Base_Base_implementation.F90:             _ASSERT(.false., 'only 2D and 3D are supported')
base/Base/Base_Base_implementation.F90:             _ASSERT(.false., 'only 2D and 3D are supported')
base/Base/Base_Base_implementation.F90:             _ASSERT(.false., 'only up to 4D are supported')
base/Base/Base_Base_implementation.F90:             _ASSERT(.false., 'only up to 4D are supported')
base/Base/Base_Base_implementation.F90:             _ASSERT(.false., 'unsupported rank > 1')
base/Base/Base_Base_implementation.F90:             _ASSERT(.false., 'unsupported rank > 1')
base/Base/Base_Base_implementation.F90:            _ASSERT(.false.,'Inconsistent number of split separators')
base/Base/Base_Base_implementation.F90:          _ASSERT(.false., 'only 2D and 3D are supported')
base/Base/Base_Base_implementation.F90:          _ASSERT(.false., 'only upto 4D are supported')
base/Base/Base_Base_implementation.F90:          _ASSERT(.false.,'if not isCubed, localSearch must be .true.')
base/Base/Base_Base_implementation.F90:       _ASSERT(.false., "R8 overload not implemented yet")
base/Base/Base_Base_implementation.F90:       _ASSERT(.false., 'only 2D and 3D are supported')
base/Base/Base_Base_implementation.F90:       _ASSERT(.false., 'rank > 4 not supported')
base/Base/Base_Base_implementation.F90:       _ASSERT(.false., 'unsupported fieldRank (> 3)')
base/Base/Base_Base_implementation.F90:       _ASSERT(.false., 'unsupported typekind')
base/Base/Base_Base_implementation.F90:       _ASSERT(.false., 'unsupported typekind+rank')
base/BinIO.F90:       _ASSERT(.false., "ERROR: unsupported RANK")
base/BinIO.F90:!ALT             _ASSERT(.false.,'failed mapl_statevarread')
base/ESMFL_Mod.F90:               _ASSERT(.false., 'unsupported rank (>= 4)')
base/ESMFL_Mod.F90:           _ASSERT(.false., 'no unused slot for halo types')
base/FileIOShared.F90:          _ASSERT(.false., 'unsupported tkr')
base/FileIOShared.F90:       _ASSERT(.false., 'unsupported tkr')
base/FileIOShared.F90:    _ASSERT(.false., 'unsupported code block') !ALT this section is questionable
base/FileMetadataUtilities.F90:            _ASSERT(.false.,"unsupported coordel variable type")
base/FileMetadataUtilities.F90:            _ASSERT(.false.,'units must be string')
base/FileMetadataUtilities.F90:            _ASSERT(.false.,'units must be string')
base/FileMetadataUtilities.F90:           _ASSERT(.false.,"unsupported time unit")
base/FileMetadataUtilities.F90:         _ASSERT(.false.,"Time unit must be character")
base/FileMetadataUtilities.F90:         _ASSERT(.false.,"unsupported time variable type")
base/FileMetadataUtilities.F90:         _ASSERT(.false.,'unsupport subclass for units')
base/FileMetadataUtilities.F90:         _ASSERT(.false.,'unsupport subclass for units')
base/FileMetadataUtilities.F90:         _ASSERT(.false.,'unsupport subclass for units')
base/FileMetadataUtilities.F90:         _ASSERT(.false.,'unsupport subclass for units')
base/FileMetadataUtilities.F90:         _ASSERT(.false.,'unsupport subclass for units')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported type kind')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported type-kind')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported typekind')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported typekind')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported typekind')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported typekind')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported typekind')
base/MAPL_AbstractRegridder.F90:            _ASSERT(.false., 'unsupported typekind')
base/MAPL_AbstractRegridder.F90:         _ASSERT(.false., 'unsupported rank')
base/MAPL_AbstractRegridder.F90:         _ASSERT(.false., 'unsupported rank')
base/MAPL_AbstractRegridder.F90:         _ASSERT(.false., 'unsupported rank')
base/MAPL_AbstractRegridder.F90:         _ASSERT(.false., 'unsupported rank')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_AbstractRegridder.F90:      _ASSERT(.false., 'unimplemented - must override in subclass')
base/MAPL_CFIO.F90:                _ASSERT(.false., 'Ungridded attributes for variables in collection do not match') 
base/MAPL_CFIO.F90:                _ASSERT(.false.,'must rotate LL')
base/MAPL_CFIO.F90:                _ASSERT(.false.,'needs informative message')
base/MAPL_CFIO.F90:               _ASSERT(.false.,'must rotate LL')
base/MAPL_CFIO.F90:             _ASSERT(.false., 'ERROR: Mixed 3d and UNGRIDDED in CFIO not allowed')
base/MAPL_CFIO.F90:             _ASSERT(.false., 'ERROR: Need bigger table with storedCoords')
base/MAPL_CFIO.F90:             _ASSERT(.false., 'ERROR: Outputting variables with different ungridded sizes in one collection')
base/MAPL_CFIO.F90:          _ASSERT(.false., 'ERROR: Mixed Vlocation in CFIO not allowed unless LEVELS is specified')
base/MAPL_CFIO.F90:          _ASSERT(.false., 'ERROR: Specifying LEVELS is not allowed for UNGRIDDED vars')
base/MAPL_CFIO.F90:       _ASSERT(.false., 'Order must be present')
base/MAPL_CFIO.F90:    _ASSERT(MCFIO%CREATED, 'MCFIO%CREATED is false')
base/MAPL_CFIO.F90:    _ASSERT(MCFIO%CREATED, 'MCFIO%CREATED is false')
base/MAPL_CFIO.F90:    _ASSERT(MCFIO%CREATED, 'MCFIO%CREATED is false')
base/MAPL_Comms.F90:       _ASSERT(.false., 'unsupported action')
base/MAPL_CubedSphereGridFactory.F90:            _ASSERT(.false.,"can not identify dimenions of cubed-sphere file")
base/MAPL_CubedSphereGridFactory.F90:            _ASSERT(.false.,'unsupport subclass for stretch params')
base/MAPL_CubedSphereGridFactory.F90:            _ASSERT(.false.,'unsupport subclass for stretch params')
base/MAPL_CubedSphereGridFactory.F90:            _ASSERT(.false.,'unsupport subclass for stretch params')
base/MAPL_LocStreamMod.F90:       _ASSERT(.false.,'needs informative message')
base/MAPL_LocStreamMod.F90:     _ASSERT(.FALSE.,'needs informative message')
base/MAPL_LocStreamMod.F90:     _ASSERT(.false.,"Can not compute variance and sample in LocStream!")
base/MAPL_LocStreamMod.F90:     _ASSERT(.false.,"Can not compute variance and transpose in LocStream!")
base/MAPL_NewArthParser.F90:                   _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:             _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:          _ASSERT(.FALSE.,'needs informative message')
base/MAPL_NewArthParser.F90:       _ASSERT(.FALSE.,'needs informative message')
base/MAPL_TimeMethods.F90:       _ASSERT(.false., 'Not supported yet')
base/MAPL_TimeMethods.F90:       _ASSERT(.false.,'time string is not a valid format')
base/MAPL_TimeMethods.F90:       _ASSERT(.false.,'unsupported subclass for units')
base/MAPL_VerticalMethods.F90:                   _ASSERT(.false.,'Ungridded attributes for variables in collection do not match')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:            _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'HK: Solar band weightings only available for Chou')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:         _ASSERT(.false.,'needs informative message')
base/MAPL_sun_uc.F90:      _ASSERT(.FALSE.," pmn: this routine is not up to date, is it even used anywhere?")
base/NCIO.F90:                     _ASSERT(.false., "  Could not find field "//trim(FieldName)//" in "//trim(filename))
base/NCIO.F90:                     _ASSERT(.false.,'units must be string')
base/NCIO.F90:                    _ASSERT(.false., "  Could not find field "//trim(Fieldname)//" in "//trim(filename))
base/NCIO.F90:                   _ASSERT(.false., 'ERROR: LOCATION not recognized for rank 1')
base/NCIO.F90:                   _ASSERT(.false., 'ERROR: LOCATION not recognized for rank 3')
base/NCIO.F90:                   _ASSERT(.false., 'ERROR: LOCATION not recognized for rank 4')
base/NCIO.F90:                _ASSERT(.false., "Unsupported DIMS type")
base/NCIO.F90:                _ASSERT(.false., "Unsupported DIMS type")
base/NCIO.F90:                _ASSERT(.false., 'ERROR: What else could it be')
base/NCIO.F90:                _ASSERT(.false., 'ERROR: What else could it be')
base/NCIO.F90:                _ASSERT(.false., 'ERROR: tiles with 2 or more UNGRIDDED dims not supported')
base/NCIO.F90:                _ASSERT(.false., 'unsupported Dims case')
base/NCIO.F90:                _ASSERT(.false., trim(buffer))
base/NCIO.F90:             _ASSERT(.false., "Cannot read unassociated variable")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated var-1d")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated var-2d")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated var-3d")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated var8-1d")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated var8-2d")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated var8-3d")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated vars")
base/NCIO.F90:             _ASSERT(.false., "Cannot write unassociated vars")
base/NCIO.F90:             _ASSERT(.false., "Unsupported type/rank")
base/NCIO.F90:             _ASSERT(.false., trim(buffer))
base/NCIO.F90:          _ASSERT(.false., "ERROR: unsupported RANK/KIND")
base/NCIO.F90:          _ASSERT(.false., "Unsupported tile/ungrid variable")
base/NCIO.F90:       _ASSERT(.false., "ERROR: unsupported RANK")
base/NCIO.F90:       _ASSERT(.false., "The bundle you are trying to write is empty")
base/NCIO.F90:     _ASSERT(.false., 'unsupported subclass for units')
base/StringTemplate.F90:                  _ASSERT(.false.,"Invalid token in file template: "//c1//c2)
base/StringTemplate.F90:                  _ASSERT(.false.,"Using %s token with no experiment id")
base/read_parallel.H:     _ASSERT(.FALSE.,'needs informative message')
base/sun.H:            _ASSERT(.FALSE.,'pmn: MAPL_SunAnnualMean probably in error!') 
base/sun.H:            _ASSERT(.FALSE.,'pmn: MAPL_SunDailyMean probably in error!') 
base/tests/mapl_bundleio_test.F90:               _ASSERT(.false.,'found difference when compare state')
base/write_parallel.H:        _ASSERT(.FALSE.,'needs informative message')
generic/GenericCplComp.F90:             _ASSERT(.false., "Unsupported rank")
generic/GenericCplComp.F90:             _ASSERT(.false., "Unsupported rank")
generic/GenericCplComp.F90:             _ASSERT(.false.," Unsupported rank")
generic/GenericCplComp.F90:       _ASSERT(.false., "Alarm is already associated! Cannot set it again!")
generic/MAPL_Generic.F90:               _ASSERT(.false.,'needs informative message')
generic/MAPL_Generic.F90:               _ASSERT(.false.,'needs informative message')
generic/MAPL_Generic.F90:               _ASSERT(.false.,'needs informative message') ! for now
generic/MAPL_Generic.F90:            _ASSERT(.false.,'needs informative message')
generic/MAPL_Generic.F90:            _ASSERT(.false.,'needs informative message')
generic/MAPL_Generic.F90:         _ASSERT(.FALSE.,'needs informative message')
generic/MAPL_Generic.F90:         _ASSERT(.false., "Unsupported type in intrinsic_to_string")
generic/MAPL_Generic.F90:         _ASSERT(.false., "Unsupported type")
generic/MAPL_Generic.F90:         _ASSERT(.false., "Unupported type")
generic/MAPL_Generic.F90:         _ASSERT(.false.,"Unsupported type")
generic/MAPL_Generic.F90:         _ASSERT(.false.,'needs informative message')
gridcomps/ExtData/ExtDataGridCompMod.F90:                   _ASSERT(.false., 'Can not have constant bundle in ExtData.rc file')
gridcomps/ExtData/ExtDataGridCompMod.F90:                   _ASSERT(.false.,'Derived items cannot be field bundle')
gridcomps/ExtData/ExtDataGridCompMod.F90:                 _ASSERT(.False.,'Reference time for file ' // trim(item%file) // ' is too late')
gridcomps/ExtData/ExtDataGridCompMod.F90:                 _ASSERT(.false., 'From ' // trim(item%file) // ' could not find file with extrapolation')
gridcomps/ExtData/ExtDataGridCompMod.F90:              _ASSERT(.False.,'ERROR: Time stamp ' // trim(template) // ' uses the fixed format, and must therefore contain a T')
gridcomps/ExtData/ExtDataGridCompMod.F90:              _ASSERT(.false., 'ERROR: File template ' // item%file // ' has invalid reference date format')
gridcomps/ExtData/ExtDataGridCompMod.F90:              _ASSERT(.false., 'cyclic keyword was not y, n, or a valid year (0 < year < 3000)')
gridcomps/ExtData/ExtDataGridCompMod.F90:              _ASSERT(.false.,'From ' // trim(item%file) // ' could not find time no extrapolation')
gridcomps/ExtData/ExtDataGridCompMod.F90:            _ASSERT(.false.,'Cannot assign constant to field bundle')
gridcomps/ExtData/ExtDataGridCompMod.F90:            _ASSERT(.false.,'Cannot perform vertical interpolation on field bundle')
gridcomps/ExtData/ExtDataGridCompMod.F90:            _ASSERT(.false.,'Cannot perform vertical interpolation on field bundle')
gridcomps/ExtData/ExtDataGridCompMod.F90:          _ASSERT(.false.,'Rank must be 2 or 3')
gridcomps/ExtData/ExtDataGridCompMod.F90:          _ASSERT(.false.,'Rank must be 2 or 3')
gridcomps/ExtData/ExtDataGridCompMod.F90:          _ASSERT(.false.,'Rank must be 2 or 3')
gridcomps/ExtData/ExtDataGridCompMod.F90:       _ASSERT(.false., error_msg_str)
gridcomps/History/MAPL_HistoryGridComp.F90:                     _ASSERT(.false.,'arithmetic expression has two different vlocations')
gridcomps/History/MAPL_HistoryGridComp.F90:                _ASSERT(.false.,'needs informative message')
gridcomps/History/MAPL_HistoryGridComp.F90:                _ASSERT(.false.,'needs informative message')
gridcomps/History/MAPL_HistoryGridComp.F90:          _ASSERT(.false. ,'The field rank is not implmented')
gridcomps/History/MAPL_HistoryGridComp.F90:       _ASSERT(.false.,'needs informative message')
gridcomps/History/MAPL_HistoryTrajectoryMod.F90:            _ASSERT(.false.,"Time unit must be character")
griddedio/GriddedIO.F90:           _ASSERT(.false., 'Unsupported field rank')
griddedio/GriddedIO.F90:           _ASSERT(.false.,'rank not supported')
griddedio/GriddedIO.F90:           _ASSERT(.false.,'rank not supported')
griddedio/GriddedIO.F90:         _ASSERT(.false., "Rank not supported")
griddedio/Regrid_Util.F90:       _ASSERT(.false.,'needs informative message')
include/MAPL_ErrLog.h:#    define _FAIL(msg) _ASSERT(.false.,msg)
pfio/AbstractDataReference.F90:               _ASSERT(.false.,"type not supported yet")
pfio/AbstractDataReference.F90:               _ASSERT(.false.,"type not supported yet")
pfio/AbstractDataReference.F90:               _ASSERT(.false.,"type not supported yet")
pfio/AbstractDataReference.F90:               _ASSERT(.false.,"type not supported yet")
pfio/AbstractDataReference.F90:               _ASSERT(.false.,"type not supported yet")
pfio/AbstractDataReference.F90:               _ASSERT(.false.,"type not supported yet")
pfio/AbstractDataReference.F90:            _ASSERT(.false.,"dimension not supported yet")
pfio/AbstractDataReference.F90:        _ASSERT(.false.,"ranks do not agree (probably fixable)")
pfio/AbstractServer.F90:     _ASSERT(.false.," no action of receive_output_data")
pfio/AbstractServer.F90:     _ASSERT(.false.," no action of server_get_DataFromMem")
pfio/AbstractServer.F90:     _ASSERT(.false.," no action of server_put_DataToFile")
pfio/ArrayReference.F90:         _ASSERT(.false., "ArrayRef does not support this type")
pfio/ArrayReference.F90:         _ASSERT(.false., "ArrayRef does not support this type")
pfio/ArrayReference.F90:         _ASSERT(.false., "ArrayRef does not support this type")
pfio/ArrayReference.F90:         _ASSERT(.false., "ArrayRef does not support this type")
pfio/ArrayReference.F90:         _ASSERT(.false., "ArrayRef does not support this type")
pfio/ArrayReference.F90:         _ASSERT(.false., "ArrayRef does not support this type")
pfio/ArrayReference.F90:         _ASSERT(.false.,'kind error')
pfio/BaseServer.F90:              _ASSERT(.false., "remote is a must")
pfio/BaseServer.F90:         _ASSERT(.false., "wrong socket type")
pfio/ClientThread.F90:        _ASSERT(.false., " should get id message")
pfio/ClientThread.F90:        _ASSERT(.false., " should get id message")
pfio/ClientThread.F90:        _ASSERT(.false., " should get id message")
pfio/CoordinateVariable.F90:            _ASSERT(.false., "not supportted type")
pfio/CoordinateVariable.F90:         _ASSERT(.false., "wrong type")
pfio/CoordinateVariable.F90:         _ASSERT(.false., 'wrong type')
pfio/CoordinateVariable.F90:         _ASSERT(.false., 'wrong type')
pfio/CoordinateVariable.F90:         _ASSERT(.false., 'wrong type')
pfio/CoordinateVariable.F90:         _ASSERT(.false.,"not support coord type")
pfio/FileMetadata.F90:         !_ASSERT(.false., 'FileMetadata::get_dimension() - no such dimension <'//dim_name//'>.')
pfio/LocalMemReference.F90:         _ASSERT(.false., "LocalMemRef does not support this type")
pfio/LocalMemReference.F90:         _ASSERT(.false., "LocalMemRef does not support this type")
pfio/LocalMemReference.F90:         _ASSERT(.false., "LocalMemRef does not support this type")
pfio/LocalMemReference.F90:         _ASSERT(.false., "LocalMemRef does not support this type")
pfio/LocalMemReference.F90:         _ASSERT(.false., "LocalMemRef does not support this type")
pfio/LocalMemReference.F90:         _ASSERT(.false., "LocalMemRef does not support this type")
pfio/MessageVisitor.F90:         _ASSERT(.false., 'unsupported subclass')
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_AddExtCollection should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_AddHistCollection should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_CollectivePrefetchData should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_CollectiveStageData should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_Done should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_Done_collective_prefetch should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_Done_collective_stage should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_Done_prefetch should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_Done_stage should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_HandShake should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_ID should not be called. hint: maybe server and app are the same?")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_ModifyMetadata should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_PrefetchData should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_StageData should not be called")
pfio/MessageVisitor.F90:      _ASSERT(.false., "Warning : dummy handle_Terminate should not be called")
pfio/MultiCommServer.F90:                  _ASSERT(.false., "I expect localmemReference")
pfio/MultiCommServer.F90:               _ASSERT(.false., "I expect CollectiveStageDataMessage")
pfio/MultiGroupServer.F90:                     _ASSERT(.false., "scalar ?? ")
pfio/MultiGroupServer.F90:              _ASSERT(.false., "yet to implemented")
pfio/MultiGroupServer.F90:        _ASSERT(.false. , "hey backend does not call this")
pfio/MultiLayerServer.F90:                    _ASSERT(.false., "remote is a must")
pfio/NetCDF4_FileFormatter.F90:         _ASSERT(.false.,"read or write mode")
pfio/ServerThread.F90:                  _ASSERT(.false., " need a remote pointer")
pfio/ServerThread.F90:              _ASSERT(.false., "Not supported type")
pfio/ServerThread.F90:              _ASSERT(.false., "Not supported type")
pfio/ServerThread.F90:              _ASSERT(.false., "not supported type")
pfio/ServerThread.F90:              _ASSERT(.false., "not supported type")
pfio/ServerThread.F90:            _ASSERT(.false., "Wrong message type")
pfio/ServerThread.F90:            _ASSERT(.false., "Wrong message type")
pfio/ServerThread.F90:            _ASSERT(.false., "receive_output_data")
pfio/ServerThread.F90:           _ASSERT(.false., "Message type should be CollectivePrefetchDataMessage ")
pfio/ServerThread.F90:         _ASSERT(.false., "Wrong message type")
pfio/ServerThread.F90:         _ASSERT(.false., "please use done_collective_prefetch")
pfio/ServerThread.F90:         _ASSERT(.false., "please use done_collective_stage")
pfio/ServerThread.F90:         _ASSERT(.false., "please use done_prefetch")
pfio/ServerThread.F90:         _ASSERT(.false., "please use done_stage")
pfio/ServerThread.F90:        _ASSERT(.false., "wrong PrefetchDataMessage type")
pfio/ServerThread.F90:        _ASSERT(.false., "wrong StageDataMessage type")
pfio/SimpleSocket.F90:         _ASSERT(.false.,"Simple should connect Simple")
pfio/UnlimitedEntity.F90:              _ASSERT(.false., "UnlimitedEntity deserialize not support")
pfio/UnlimitedEntity.F90:              _ASSERT(.false., "UnlimitedEntity deserialize not support")
pfio/UnlimitedEntity.F90:            _ASSERT(.false.," type is not supported")
pfio/UnlimitedEntity.F90:            _ASSERT(.false.," type is not supported")
pfio/UnlimitedEntity.F90:        _ASSERT(.false., 'not support type')
pfio/UnlimitedEntity.F90:        _ASSERT(.false., 'not support type')
pfio/UnlimitedEntity.F90:        _ASSERT(.false., 'not support type')
pfio/UnlimitedEntity.F90:        _ASSERT(.false., 'not support type')
pfio/UnlimitedEntity.F90:        _ASSERT(.false., 'unsupported unless shape is [1]')
pfio/pFIO_Utilities.F90:         _ASSERT(.false., "unsupported type kind")
pfio/pfio_writer.F90:              _ASSERT(.false., "not supported type")
pfio/pfio_writer.F90:              _ASSERT(.false., "not supported type")
shared/MAPL_HeapMod.F90:            _ASSERT(.false.,'needs informative message')
shared/MAPL_HeapMod.F90:            _ASSERT(.false.,'needs informative message')
shared/MAPL_HeapMod.F90:         _ASSERT(.false.,'needs informative message')
shared/MAPL_HeapMod.F90:         _ASSERT(.false.,'needs informative message')
shared/Shmem/Shmem_implementation.F90:            _ASSERT(.false.,'needs informative message')

Something for a rainy day...

@mathomp4 mathomp4 added the 🛠️ Refactor This is code refactoring label Feb 17, 2022
@mathomp4 mathomp4 self-assigned this Feb 17, 2022
@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days, it will be closed. You can add the "long term" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the ❄️ Stale This issue has been marked stale label Apr 18, 2022
@mathomp4 mathomp4 added the ⌛ Long Term Long term issues label Apr 19, 2022
@stale stale bot removed the ❄️ Stale This issue has been marked stale label Apr 19, 2022
@mathomp4
Copy link
Member Author

Setting this as long-term. I think @bena-nasa fixed some of these recently, but I'm sure some still remain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ Refactor This is code refactoring ⌛ Long Term Long term issues
Projects
None yet
Development

No branches or pull requests

1 participant