Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect file timestamp with 24-hour duration and 1-hour frequency time-average #1064

Closed
LiamBindle opened this issue Oct 7, 2021 · 5 comments · Fixed by #1075
Closed

Incorrect file timestamp with 24-hour duration and 1-hour frequency time-average #1064

LiamBindle opened this issue Oct 7, 2021 · 5 comments · Fixed by #1075
Assignees
@bena-nasa @atrayano
Labels
🪲 Bugfix This fixes a bug!

Comments

@LiamBindle
Copy link
Contributor

Follow up from today's GCHP-MAPL call.

Collections with mode time-average, frequency 1-hour, and duration 24-hour aren't timestamped correctly (with the default Reference of 000000). If you enable timestampStart the files are stamped the previous day at 23:00. I believe that without timestampStart they are stamped at 23:30 of the previous day.
@LiamBindle LiamBindle added the 🪲 Bugfix This fixes a bug! label Oct 7, 2021
@LiamBindle
Copy link
Contributor Author

Here is the issue where it was first reported: geoschem/GCHP#162

@LiamBindle LiamBindle mentioned this issue Oct 7, 2021
Closed
@tclune tclune closed this as completed in 606b714 Oct 12, 2021
tclune added a commit that referenced this issue Oct 12, 2021
@tclune
Merge pull request #1069 from GEOS-ESM/hotfix/atrayano/#1064_incorrec…
ac39ab5 
…t_file_timestamp

Fixes #1064. This bug has been in MAPL for a long time (classical "fe…
This was referenced Oct 12, 2021
Closed
Merged
mathomp4 added a commit that referenced this issue Oct 12, 2021
@mathomp4
Merge pull request #1073 from GEOS-ESM/develop
c7d604d 
Auto PR - develop → MAPL-v3 - Fixes #1064. This bug has been in MAPL for a long time (classical fence-post problem). Once the new segment alarm rings, the new file should be open only after the current time step is written.
mathomp4 added a commit that referenced this issue Oct 13, 2021
@mathomp4
Revert "Fixes #1064. This bug has been in MAPL for a long time (class…
672c09b 
…ical "fence-post" problem). Once the new segment alarm rings, the new file should be open only after the current time step is written."

This reverts commit 606b714.
@mathomp4 mathomp4 mentioned this issue Oct 13, 2021
Merged
7 tasks
@mathomp4 mathomp4 reopened this Oct 13, 2021
@mathomp4
Copy link
Member

Re-opening as #1069 had side-effects, see #1074

@mathomp4
Copy link
Member

Sigh. Re-opening again. I guess I used a "closing keyword" with GitHub.

@mathomp4 mathomp4 reopened this Oct 13, 2021
@atrayano
Copy link
Contributor

I found what went wrong with my earlier "fix". Moving the logical variable NewSeg logic to a different location ended up being in another do-loop, and as a result NewSeg was overwritten by each iteration of the first loop. I promoted newSeg to an array and that resolved the issue. And new PR is coming shortly

mathomp4 added a commit that referenced this issue Oct 15, 2021
@mathomp4
Merge pull request #1082 from GEOS-ESM/hotfix/atrayano/#1064_incorrec…
8fedac9 
…t_new_file

Fixes #1064. Fixed error related to NewSeg logic
@github-actions github-actions bot mentioned this issue Oct 15, 2021
Closed
@LiamBindle
Copy link
Contributor Author

Thanks @atrayano and @mathomp4!

@LiamBindle LiamBindle mentioned this issue Oct 15, 2021
Merged
7 tasks
@github-actions github-actions bot mentioned this issue Oct 15, 2021
Merged
mathomp4 added a commit that referenced this issue Oct 15, 2021
@mathomp4
Merge pull request #1087 from GEOS-ESM/develop
631e782 
Auto PR - develop → MAPL-v3 - Fixes #1064. Fixed error related to NewSeg logic
@mathomp4 mathomp4 mentioned this issue Oct 15, 2021
Merged
tclune pushed a commit that referenced this issue Oct 26, 2021
@mathomp4 @tclune
Revert "Fixes #1064. This bug has been in MAPL for a long time (class…
28c09f6 
…ical "fence-post" problem). Once the new segment alarm rings, the new file should be open only after the current time step is written."

This reverts commit 606b714.
tclune pushed a commit that referenced this issue Oct 26, 2021
@mathomp4 @tclune
Revert "Fixes #1064. This bug has been in MAPL for a long time (class…
0d0d68c 
…ical "fence-post" problem). Once the new segment alarm rings, the new file should be open only after the current time step is written."

This reverts commit 606b714.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bena-nasa bena-nasa

@atrayano atrayano

Labels
🪲 Bugfix This fixes a bug!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert fix in 2.8.7 GEOS-ESM/MAPL
4 participants
@mathomp4 @LiamBindle @bena-nasa @atrayano