Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GEOSgcm (and thus GEOSadas) will soon move to use Intel oneAPI 2024.2 which is Intel
ifort
2021.13 andicx
2024.2.Tests showed two issues. First there was a plain Fortran bug in
GMAO_ods/ods_diagnc4.F90
:That trailing comma is just wrong. Per @gmao-msienkie below, this should be a "." and is such now.
icx
also threw an error with some C code:As the error states, we add
#include <stdlib.h>