Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pmn: hotfix to tmin_selectable #24

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Aug 16, 2023

Bug fix for bug found by @sdrabenh.

I'll keep draft until this can be tested.

@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Aug 16, 2023
@mathomp4 mathomp4 self-assigned this Aug 16, 2023
@mathomp4 mathomp4 requested a review from a team as a code owner August 16, 2023 16:15
@mathomp4 mathomp4 marked this pull request as draft August 16, 2023 16:16
@mathomp4
Copy link
Member Author

Note: It seems to work fine for me, but I only did a bit of a toy test (I moved one of the MAPL_GetResource calls out of the if-block just to see if it would run.)

Hopefully @sdrabenh can try it with a case that actually triggered this and be the ultimate test.

@dr0cloud
Copy link
Collaborator

dr0cloud commented Aug 16, 2023 via email

@sdrabenh
Copy link
Contributor

Note: It seems to work fine for me, but I only did a bit of a toy test (I moved one of the MAPL_GetResource calls out of the if-block just to see if it would run.)

Hopefully @sdrabenh can try it with a case that actually triggered this and be the ultimate test.

@mathomp4 it worked for me

@mathomp4 mathomp4 marked this pull request as ready for review August 22, 2023 17:45
@mathomp4 mathomp4 merged commit 72d8b05 into main Aug 22, 2023
@mathomp4 mathomp4 deleted the hotfix/pnorris/tmin_selectable branch August 22, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants