GitFlow: Merge Develop into Main for a release #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the CI to point to Baselibs 7.13.0 which is the version used by GEOSgcm on `main`
This PR updates the CircleCI config to default to using the Baselibs in the CircleCI orb rather than explicitly specifying the versions. In most cases, this is the "best" way as a change to the orb can fix this for projects without the need for a PR. Note that we keep commented the explicit anchors in case needed.
…13-rad Update CI to use Orb Baselibs
…selectable pmn: use selectable tmin_OK
dr0cloud
approved these changes
Aug 1, 2023
|
Let me do a quick GEOSgcm run to make sure it's zero-diff. I mean, it seems it obviously is, but...for safety's sake :) |
|
Should be 0diff if running standard RRTMG. But if running RRTMGP it may not be 0diff if one selects those new AGCM.rc parameters different from the default values of 10. |
|
And it is! Zero-diff. Merging and will make release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the change from #21 into main for a tag