Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pnorris/#9 add obio exports for chou suarez as well #10

Merged

Conversation

dr0cloud
Copy link
Collaborator

@dr0cloud dr0cloud commented Dec 1, 2022

This is an expansion of a previous PR#3 that enabled producing of OBIO surface solar downwelling direct and diffuse fluxes on OBIO bands. The previous PR worked for RRTMG only. This PR expands the facility to all three radiation codes. It is activated by putting SOLAR_TO_OBIO: .TRUE. in AGCM.rc and then associating the solar export fields DROBIO and DFOBIO either by exporting them in history or adding future connectivity to the OradBioGC. It is off by default and therefore zero-diff. Even if it is on, it is effectively zero-diff ... it only potentially produces two currently unused new exports, now for RRTMGP and Chou-Suarez as well as for RRTMG (PR#3).

@dr0cloud dr0cloud added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Dec 1, 2022
@dr0cloud dr0cloud requested a review from mathomp4 December 1, 2022 15:20
@dr0cloud dr0cloud requested a review from a team as a code owner December 1, 2022 15:20
@dr0cloud dr0cloud self-assigned this Dec 1, 2022
@dr0cloud
Copy link
Collaborator Author

dr0cloud commented Dec 1, 2022

Oops, like last time I meant to merge this into develop first then main, not other way around. Can I change that now, or we can just do it in the reverse order as we did for PR#3?

@mathomp4
Copy link
Member

mathomp4 commented Dec 1, 2022

I (or you) can change the base to be to develop. I can do it if you'd like

@dr0cloud
Copy link
Collaborator Author

dr0cloud commented Dec 1, 2022 via email

@mathomp4 mathomp4 changed the base branch from main to develop December 1, 2022 18:04
@mathomp4
Copy link
Member

mathomp4 commented Dec 1, 2022

Ah. Looks much more concise now 😄

Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

@mathomp4 mathomp4 added 0 diff structural Structural changes to repository that are zero-diff and removed 0 diff structural Structural changes to repository that are zero-diff labels Dec 1, 2022
@mathomp4 mathomp4 merged commit f3ca073 into develop Dec 2, 2022
@mathomp4 mathomp4 deleted the feature/pnorris/#9-add-OBIO-exports-for-Chou-Suarez-as-well branch December 2, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants