Code

[NDSL] QSat port#994

Code

Merged

FlorianDeconinck merged 25 commits intodsl/developGEOS-ESM/GEOSgcm_GridComp:dsl/developfrom dsl/QSatGEOS-ESM/GEOSgcm_GridComp:dsl/QSatCopy head branch name to clipboardSep 13, 2024

+912-2

Commits

Commits on Aug 14, 2024

• SaturationVaporPressureTable code first pass

  Show description for b30ae8d
  FlorianDeconinck

  committed
  b30ae8d

  Copy full SHA for b30ae8d

• QSat_Ice_scalar_exact

  FlorianDeconinck

  committed
  cde8399

  Copy full SHA for cde8399

• Fix calculation. Table generates OK.

  FlorianDeconinck

  committed
  dd15d29

  Copy full SHA for dd15d29

• Fix Murphy and CAM

  FlorianDeconinck

  committed
  e6b597c

  Copy full SHA for e6b597c

Commits on Aug 15, 2024

• Rename estimate_table -> table

  Show description for 5e4e464
  FlorianDeconinck

  committed
  5e4e464

  Copy full SHA for 5e4e464

Commits on Aug 28, 2024

• Functional QSat module. Can handle optional RAMP/PASCALS/DQSAT inputs. Fails to verify at majority of points using original metric, has not been tested with new metrics. Error patterns of the ES ta…

  Show description for b80185c
  CharlesKrop

  committed
  b80185c

  Copy full SHA for b80185c

• More clean up, first attempt at QSat function

  CharlesKrop

  committed
  1065cff

  Copy full SHA for 1065cff

• Working QSat function. QSat class can still be called outside of stencil to calculate QSat for entire field, or function can be called from within the stencil to calculate QSat at individual points…

  Show description for 76b6ec5
  CharlesKrop

  committed
  76b6ec5

  Copy full SHA for 76b6ec5

Commits on Sep 3, 2024

• Minor change for improved DQSAT functionality

  CharlesKrop

  committed
  fdbf8aa

  Copy full SHA for fdbf8aa

• Minor change for improved DQSAT functionality

  CharlesKrop

  committed
  035f1a9

  Copy full SHA for 035f1a9

• Two new functions: QSat_Float_Liquid and QSat_Float_Ice. These two functions are a port of QSATLQU0/QSATICE0 when UTBL is false.

  Show description for d826f35
  CharlesKrop

  committed
  d826f35

  Copy full SHA for d826f35

Commits on Sep 5, 2024

• Tiny little bugfix fro QSat_Float_Liquid and QSat_Float_Ice

  CharlesKrop

  committed
  5aa9b48

  Copy full SHA for 5aa9b48

Commits on Sep 6, 2024

• Fixed indexing error in QSat_Float_Liquid/Ice, and inserted a workaround for bad interaction between dace backend and cast to int

  CharlesKrop

  committed
  b4998d6

  Copy full SHA for b4998d6

Commits on Sep 10, 2024

• Code cleanup, ready to be pulled back into main branch

  CharlesKrop

  committed
  5cc9dd6

  Copy full SHA for 5cc9dd6

• Few more cleanups, modification to translate test to test sat tables

  CharlesKrop

  committed
  d9d13ed

  Copy full SHA for d9d13ed

Commits on Sep 11, 2024

• QSat verifies if tables are read in from netcdf (this is the current state of the code). Generated tables do not yet verify.

  CharlesKrop

  committed
  b4d35f9

  Copy full SHA for b4d35f9

Commits on Sep 12, 2024

• Merge branch 'dsl/develop' into dsl/QSat

  

  Florian Deconinck

  committed
  a93a35e

  Copy full SHA for a93a35e

• Fix run tests

  

  Florian Deconinck

  committed
  1c96c31

  Copy full SHA for 1c96c31

• Functional QSat module. Table calculations are still incorrect due to differences between Fortran and C interpretation of constants (see GEOS-ESM/SMT-Nebulae#88 for more information). Table values …

  Show description for e3c636e
  CharlesKrop

  committed
  e3c636e

  Copy full SHA for e3c636e

• Forgot to apply fix to other QSat functions. All functions now work properly

  CharlesKrop

  committed
  534dcc9

  Copy full SHA for 534dcc9

Commits on Sep 13, 2024

• Linting

  

  Florian Deconinck

  committed
  6bd9006

  Copy full SHA for 6bd9006

• Refactor table_method to an enum

  Show description for 4c2609e
  

  Florian Deconinck

  committed
  4c2609e

  Copy full SHA for 4c2609e

• Clean up translate test

  Show description for c138b46
  

  Florian Deconinck

  committed
  c138b46

  Copy full SHA for c138b46

• Revert run_tests.sh to common one

  

  Florian Deconinck

  committed
  8e5b5cc

  Copy full SHA for 8e5b5cc

• Clean up debug fields for table

  

  Florian Deconinck

  committed
  ece972f

  Copy full SHA for ece972f