[NDSL] QSat port #994
Merged
[NDSL] QSat port #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QSatIce missing before test can be done
Verbose the README
…. Fails to verify at majority of points using original metric, has not been tested with new metrics. Error patterns of the ES tables suggest arise during math within qsat_liquid and qsat_ice. Errors are small (10^-4). Further testing using find_klcl is in process to see if these errors propogate further or are locked within QSat.
…cil to calculate QSat for entire field, or function can be called from within the stencil to calculate QSat at individual points. To use function, the QSat class must be initialized before stencil call and the tables must be passed down to the function as an input.
…nctions are a port of QSATLQU0/QSATICE0 when UTBL is false. Notable difference from QSat_Float: QSat_Float features a smooth transition from ice to liquid water (based on the TMIX parameter) while these two functions have a hard transition at 0C (should transition from calling one to the other). UNTESTED FOR NOW, NO EASILY ACCESSABLE TEST CASE
…und for bad interaction between dace backend and cast to int
FlorianDeconinck
requested changes
Sep 10, 2024
…state of the code). Generated tables do not yet verify.
… differences between Fortran and C interpretation of constants (see GEOS-ESM/SMT-Nebulae#88 for more information). Table values are instead read in from netCDF file as a temporary solution.
Rename formulation to types
Revert run_tests.sh to common one
FlorianDeconinck
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional port of GEOS_QSat function (and related calls). Function currently fails at majority of points (~86%) with old metric. New metric (not currently working on my machine) should show that these errors are small enough to be considered acceptable.
Errors can be traces back to differences in saturation pressure tables generates at QSat init. It is believed that these errors pop up because these tables are generated in standard python (gt4py is missing adequate extra dimension capabilities) and therefore executed in 64 bit