Restructure DO_OBIO #367
Merged
Restructure DO_OBIO #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
October 14, 2020 14:08
… it was used by USE_ODAS, which now defunct
…nbiogeochem_GridComp TO GEOS_OceanBioGeoChemGridComp, (ii) GEOSorad_GridComp TO GEOS_OradBioGridComp, (iii) GEOSoradbio_GridComp TO GEOS_OradGridComp. Notice that GEOSocean_GridComp and GEOSseaice_GridCom also do not confirm to current naming conventions, and they will be handled in a _future_ restructing exercise
…ports if DO_OBIO _is not equal to_ 0. Hence all that GEOS_SaltWaterGridComp.F90 now does is to add this child if the condition: DO_OBIO =/0 is satisfied.
…is now _protected_ by DO_OBIO/= 0. FYI @yvikhlya and thanks
yvikhlya
approved these changes
Oct 21, 2020
sdrabenh
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
resolves #362
In addition to the details in the above issue #362
following GEOS convention as per @tclune 's suggestion, few directories and file names in
GEOSgcm_GridComp/GEOSogcm_GridComp/have been renamed.Changes are zero-diff in coupled and uncoupled configurations