turn off GOSWIM via N_constit=0 #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiyuan-jiang
previously approved these changes
Feb 8, 2025
|
Testing summary:
|
biljanaorescanin
previously approved these changes
Feb 10, 2025
lcandre2
previously approved these changes
Feb 10, 2025
sdrabenh
previously approved these changes
Feb 21, 2025
6c47e62
…ceding (manual-assisted) merge commit of "develop"; for the record, the indentation in GEOS_LandIceGridComp.F90 is a mess and needs fixing
…lost in preceding (manual-assisted) merge commit of "develop"
biljanaorescanin
approved these changes
Feb 21, 2025
sdrabenh
approved these changes
Feb 21, 2025
mathomp4
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The present PR attempts to turn off GOSWIM by setting the number of constituents to 0.
GOSWIM is a snow impurity scheme that was implemented in GEOS but has not been used.
Previously, N_constit=9 was hardwired and GOSWIM calculations were executed even though GOSWIM was never used. To turn off GOSWIM, the GCM's rc parameter AEROSOL_DEPOSITION was set to 0, which forced the constituent mass and the deposition rates to remain zero, but the many GOSWIM do loops through the 9 constituents were still executed, thus multiplying and adding lots zeros many times.
If needed, original behavior can be recovered by setting N_constit=N_constit_GOSWIM=9 in StieglitzSnow.F90
Successfully 0-diff tested for GEOSldas after 8254a10 (@gmao-rreichle)
If GOSWIM or a revised snow impurity scheme is used in future, N_constit should be configurable (see also the existing rc variables
N_CONST_LAND[ICE]4SNWALB).