Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uptick to v10.19.4 #340

Merged
merged 5 commits into from
Oct 7, 2021
Merged

Uptick to v10.19.4 #340

merged 5 commits into from
Oct 7, 2021

Conversation

sdrabenh
Copy link
Collaborator

@sdrabenh sdrabenh commented Oct 7, 2021

No description provided.

@sdrabenh sdrabenh added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. Contingent - DNA These changes are contingent on other PRs labels Oct 7, 2021
@sdrabenh sdrabenh requested a review from mathomp4 October 7, 2021 18:29
@sdrabenh sdrabenh requested a review from a team as a code owner October 7, 2021 18:29
@sdrabenh sdrabenh requested a review from a team as a code owner October 7, 2021 18:32
tclune
tclune previously approved these changes Oct 7, 2021
View reviewed changes
Copy link
Contributor

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake changes ok

mathomp4
mathomp4 previously approved these changes Oct 7, 2021
View reviewed changes
@sdrabenh sdrabenh dismissed stale reviews from mathomp4 and tclune via e8c3605 October 7, 2021 18:55
@mathomp4 mathomp4 self-requested a review October 7, 2021 18:56
mathomp4
mathomp4 previously approved these changes Oct 7, 2021
View reviewed changes
Copy link
Member

@mathomp4 mathomp4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approve!

@sdrabenh sdrabenh removed the Contingent - DNA These changes are contingent on other PRs label Oct 7, 2021
@sdrabenh sdrabenh merged commit c1626d1 into main Oct 7, 2021
@sdrabenh sdrabenh deleted the sdrabenh-patch-1 branch October 7, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathomp4 mathomp4 mathomp4 approved these changes

@tclune tclune tclune left review comments

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdrabenh @mathomp4 @tclune