Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOS-Chem 14.5.1 and dependencies #287

Open
wants to merge 7 commits into
base: geos/latest_gcc
Choose a base branch
from

Conversation

lizziel
Copy link
Collaborator

@lizziel lizziel commented Jan 14, 2025

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR is for compatibility with GEOS-Chem 14.5.1 and its dependencies. Changes include:

  • Add HETP subdirectory to store new submodule HETP (https://github.com/geoschem/HETerogeneous-vectorized-or-Parallel). CMake files are included in the HETP subdirectory to use for the build.
  • Update Cloud-J CMake file for new filenames used in Cloud-J version 8.0.1.
  • Update call to open HEMCO log within HEMCO_GridCompMod.F90 for compatibility with HEMCO 3.10.1.

Note that the HETP submodule is not included in this PR because it will be cloned during the mepo stage when building GEOSgcm.

Related PRs

Once this and the HEMCO, GEOS-Chem, and Cloud-J PRs are merged into geos/latest_gcc then I will create a PR to update .gitmodules in GEOSgcm.

lizziel and others added 4 commits December 20, 2024 10:35
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel lizziel requested a review from viral211 January 14, 2025 21:47
@lizziel lizziel requested review from a team as code owners January 14, 2025 21:47
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel
Copy link
Collaborator Author

lizziel commented Jan 17, 2025

Regarding the build failures, I would expect this to fail because it requires updates to several submodules. That being said, it is failing much earlier:

CMake Error at src/Shared/@MAPL/CMakeLists.txt:80 (message):
  gFTL must be at least 1.10.0

Should we ignore?

@mathomp4
Copy link
Member

Regarding the build failures, I would expect this to fail because it requires updates to several submodules. That being said, it is failing much earlier:

CMake Error at src/Shared/@MAPL/CMakeLists.txt:80 (message):
  gFTL must be at least 1.10.0

Should we ignore?

@lizziel No. Don't ignore that. If we update that, it usually means a new interface or was added or there was a but fix to the point where we now require (at least) that version.

@mathomp4
Copy link
Member

That said, you can ignore the CI. Your base branch is probably too old for my CI to work anymore. Docker images move on, etc. I can try to figure it out if you need me to, but if you know it builds and works, just press merge and be happy

Copy link
Contributor

@mmanyin mmanyin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine, with the caveat that this is branched from a version of CHEM from Sept 2022.

@mmanyin
Copy link
Contributor

mmanyin commented Jan 17, 2025

@mathomp4 - since I don't have powers to bypass the GitHub checks, please coordinate with Lizzie as to the best time to proceed with the PR, thx

@lizziel
Copy link
Collaborator Author

lizziel commented Jan 17, 2025

@Viral, looking at the git history I see an update from you off of geos/latest_gcc, in branch feature/vshah/cf2_updates. The same update is the last commit to geoscf/CFv2. Do you want me to bring that into this PR, or do you want to do a separate PR to bring it officially into geos/latest_gcc?

@viral211
Copy link

Thanks for asking @lizziel. Please bring feature/vshah/cf2_updates into the PR. I have to keep the other one separate because it tracks the codebase used for CFv2.

…feature/ewlundgr/geoschem_14.5.0_and_dependencies
Signed-off-by: Lizzie Lundgren <elundgren@seas.harvard.edu>
@lizziel
Copy link
Collaborator Author

lizziel commented Jan 21, 2025

Now merged (feature/vshah/cf2_updates) and changelog updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants