Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vb:update ana_aod.F code to handle both AOD and LAOD obs at the same … #216

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

vbuchard
Copy link
Contributor

  • Updated ana_aod.F code to be able to handle AOD (KT=45) and Log of AOD (KT=43) observations at the same time.
  • The code should work if only AOD is available or
    if only LAOD is available or
    if both of them are available at the same time.

@vbuchard vbuchard requested a review from amdasilva September 30, 2022 18:00
@vbuchard vbuchard requested a review from a team as a code owner September 30, 2022 18:00
@rtodling
Copy link
Collaborator

Virginie, you'll need to add a zero-diff or non-zero-diff label, please.

@vbuchard vbuchard added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Sep 30, 2022
@rtodling
Copy link
Collaborator

Also, in order to get zero-diff w/ the code that was there before you need to convert the data in exactly the same way as the observer is converting the obs:

ods%data%obs = max(eps,exp(ods%data%obs)-eps)

you should not do:

ods%data%obs = max(eps,exp(ods%data%obs)-0.01)

eps is a resource file parameter.

Also, how did you test? Out of the three possible cases now, did you make sure that the two previous cases give you zero diff in the increments?

@vbuchard
Copy link
Contributor Author

I tried that first by using eps but eps is not defined in ana_aod.F, so I had differences in the observations values in my test. By putting the value of eps directly in the code as being 0.01, I had 0 diff. eps is defined in the observer code m_obs.F90.

For the tests, I run ana_aod.F, followed by PSAS offline. I did not look at the increments directly since I did not touch this part of the code. I looked at how many observations were going through to the qc and if the observation values in the post-processing obs files were similar to Amal's experiment files. To look at the increment values, I need to be sure that the same background files are used.

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine w/ me - and I know the tests worked ... taking it on.

@rtodling rtodling merged commit 6da37bd into develop Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch. bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants