Fix uncovered CMake path #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tclune
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a possible uncovered CMake path in the testsuites. It's hard to reach because you need to be in a git-stripped source tree.
If you aren't in a git repo, things go a bit wonky here. There needs to be a fix in ESMA_cmake as well, but this at least closes up the "else" side here. There is no danger to the "normal get ADAS from git" pathway since it will always use the other part of the if-test.
(NOTE:
GIT_FOUNDonly looks for the executablegitnot if you're in a git repo. I guess I thought differently when doing this code. Mea culpa.)