Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking for prior calculation of virtual temperture before running 'prevents' #133

Merged
merged 18 commits into from
Dec 15, 2021

Conversation

gmao-msienkie
Copy link
Contributor

The new program check_virtmp.x will check the SFCSHP data in the input prepbufr file to determine if the virtual temperature correction has already been applied, and print out 'VIRTUAL' or 'DRY' to indicate the file state. The 'gmao_prepqc' script has been modified to dynamically create the input parameter file for 'prevents.x' based on the determination made by check_virtmp.x - i.e. the virtual temperature correction will be set to FALSE if the correction has already been applied to the input files.

This will correct a problem with the MERRA2 prepbufr files that started at the end of December 2020. Previously the configuration in their processing had not done the virtual temperature calculation for SFCSHP and ADPSFC prior to sending us the files. The double calculation of virtual temperature caused the input marine temperatures for MERRA2 to be warmer than the operational marine temperatures and may have contributed to the excessive warm tempertures in the western Atlantic that were discussed at the monitoring meeting.

This change will be zero diff for the prepQC processing until 2020/12/29 00z which is when the input stream switched to virtual temperature from dry temperature for SFCSHP and ADPSFC.

@gmao-msienkie gmao-msienkie requested review from a team as code owners November 17, 2021 23:27
@gmao-msienkie gmao-msienkie added bug Something isn't working Non 0-diff The changes in this pull request are non-zero-diff labels Nov 17, 2021
tclune
tclune previously approved these changes Nov 17, 2021
Copy link
Collaborator

@tclune tclune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes OK.

@gmao-msienkie gmao-msienkie self-assigned this Nov 18, 2021
jing-guo
jing-guo previously approved these changes Nov 18, 2021
Copy link

@jing-guo jing-guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection, but not merging the PR.

@gmao-msienkie gmao-msienkie dismissed stale reviews from jing-guo and tclune via 232a390 November 20, 2021 00:45
@gmao-msienkie
Copy link
Contributor Author

Sorry - I realized when I was adding this code to the CVS repository for the MERRA2 and CERES runs that I had not included a 'usage' statement to be printed if a command-line argument was not specified for the input file. I guess you'll have to review again. Oh, well.

@gmao-msienkie
Copy link
Contributor Author

No objection, but not merging the PR.

That's fine. This change is not needed for regular forward processing and similar tests since we don't use prepQC for those runs, we just ingest the GDAS prepbufr.
There is a pending request for a prepQC change to add the NRL ACQC that will be needed for R21C and possibly GEOS-IT (the segments that use historical data). Both that branch and this one modify the 'gmao_prepqc' script so we'll have to take some care to make sure both changes end up getting in.

@rtodling
Copy link
Collaborator

Meta, I updated your newer PR (for the aircraft stuff) before accepting this ... so there was conflict in the script - which I think I resolved; but this PR now needs your ok ... can you please look at it? Thanks

Add additional flag to parm file - set to not recalculate specific humidity
@gmao-msienkie
Copy link
Contributor Author

It looks like the merge with develop (with the ACQC change) is good. I'm setting one additional switch in the parm file to have the program not recalculate Q.

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine w/ me

@rtodling rtodling merged commit 02cdb6e into develop Dec 15, 2021
@gmao-msienkie gmao-msienkie deleted the feature/msienkie/check_prepbufr_sfcshp_virtmp branch March 9, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Non 0-diff The changes in this pull request are non-zero-diff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants