Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic was added to pass the ARCHIVE location from GEOSadas to the Pyr… #112

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Logic was added to pass the ARCHIVE location from GEOSadas to the Pyr… #112

merged 2 commits into from
Oct 4, 2021

Conversation

gmao-jstassi
Copy link
Contributor

…admon code so that it has the correct location when GEOSadas is not using the default location. This update also contains the $datamove_constraint variable and related logic from Ricardo which he was planning to add later. He said that including it now would have no impact.

@gmao-jstassi
Logic was added to pass the ARCHIVE location from GEOSadas to the Pyr…
1df643a 
…admon code so that it has the correct location when GEOSadas is not using the default location. This update also contains the $datamove_constraint variable and related logic from Ricardo which he was planning to add later. He said that including it now would have no impact.
@gmao-jstassi gmao-jstassi added the 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Sep 17, 2021
@gmao-jstassi gmao-jstassi requested a review from a team as a code owner September 17, 2021 19:16
rtodling
rtodling approved these changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Joe

@rtodling rtodling merged commit 5a3234d into develop Oct 4, 2021
@rtodling
Copy link
Collaborator

rtodling commented Oct 4, 2021

Hum ... I just realize this will break the system for most people ... you committed the props dastest lines as uncommented lines ... they need to be commented out.

@rtodling
Copy link
Collaborator

rtodling commented Oct 4, 2021

Unfortunately, I approved this before noticing ... will need a fix

@gmao-jstassi
Copy link
Contributor Author

gmao-jstassi commented Oct 4, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtodling rtodling rtodling approved these changes

Assignees
No one assigned
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gmao-jstassi @rtodling