Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jstassi/#73 integrate radmon into adas 2 #107

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

gmao-jstassi
Copy link
Contributor

Updates for integrating RADMON into ADAS

@gmao-jstassi gmao-jstassi requested a review from a team as a code owner July 26, 2021 15:42
@gmao-jstassi gmao-jstassi added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jul 26, 2021
@gmao-msienkie
Copy link
Contributor

I just wanted to mention that, rather than processing the Pyradmon gsidiag_bin2txt a month (or partial month) at a time, I think it would be more convenient to have people create the diag.txt files when running each job segment. There have been hooks for this for quite a while in the DAS scripts for running the gsidiag_bin2txt and there are listings in the silo.arc to copy the text files from $FVWORK.
To activate this, you would just need to add one line to the FVDAS_Run_Config with the command to run gsidiag_bin2txt

setenv GSI_DIAG2TXT "gsidiag_bin2txt.x -passivebc -npred 12" (or something like that with the appropriate options)

@rtodling
Copy link
Collaborator

Joe, I cannot fold this into develop - ie approve the PR - since echorc.pl is missing. I imagine you placed it in GMAO_Shared/GMAO_etc ... but I don't see it in a PR under GMAO_Shared - you'll need to do that before this can be approved or else the DAS will break.

Copy link
Collaborator

@rtodling rtodling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested myself, but it looks fine - and I trust your testing.

@rtodling rtodling merged commit 0a4490f into develop Jul 29, 2021
@mathomp4 mathomp4 deleted the feature/jstassi/#73-Integrate-RADMON-into-ADAS-2 branch July 29, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants