Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop silencing errors during launchNode startup #2248

Closed
arboleya opened this issue May 6, 2024 · 6 comments · Fixed by #2558
Closed

Stop silencing errors during launchNode startup #2248

arboleya opened this issue May 6, 2024 · 6 comments · Fixed by #2558
Assignees
Labels
bug Issue is a bug
Milestone

Comments

@arboleya
Copy link
Member

arboleya commented May 6, 2024

When using the launchNode utility, some node startup errors derived from improper configs are silenced.

This makes debugging issues tricky and prevents the utility from working as expected.

Reported by @LuizAsFight

@arboleya arboleya added bug Issue is a bug mainnet labels May 6, 2024
@arboleya arboleya added the p0 label Jun 9, 2024
@arboleya arboleya added this to the Mainnet milestone Jun 9, 2024
@arboleya arboleya removed the mainnet label Jun 9, 2024
@nedsalk
Copy link
Contributor

nedsalk commented Jun 19, 2024

@LuizAsFight it would be great if you could give an example here for us to have something concrete to work with.

@nedsalk nedsalk assigned nedsalk and unassigned nedsalk Jun 19, 2024
@petertonysmith94
Copy link
Contributor

Could this be related to #2483 do you think @nedsalk?

@nedsalk
Copy link
Contributor

nedsalk commented Jun 20, 2024

@petertonysmith94 it might be because the child's stdout and stderr are piped into the corresponding process methods.

@arboleya
Copy link
Member Author

Could it be resolved together?

@LuizAsFight
Copy link
Contributor

I don't have one example now @nedsalk , but I remember I got this by informing incorrect chainConfig or incorrect initialization params, then the error produced by the node when starting it was not being shown

@nedsalk nedsalk self-assigned this Jun 21, 2024
@nedsalk
Copy link
Contributor

nedsalk commented Jun 21, 2024

@arboleya yeah, I'll do it in #2483. I'll put that PR into draft mode until I cover everything there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants