Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage_consistency): define safe method to introduce data at genesis height #2329

Closed
1 task
rymnc opened this issue Oct 10, 2024 · 1 comment
Closed
1 task
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@rymnc
Copy link
Member

rymnc commented Oct 10, 2024

Context

In #2322 we introduced a method to rewrite some data at genesis height for the ContractsInfo table. This was done by using an unsafe operation to convert a database into its genesis stage, and writing to it then.

We need to think and rework how we do this in the future in a reliable way without the unsafe operation.

Definition of Done

  • We can load data that was missed in the initial genesis snapshot at a later date to the genesis height of various tables without unsafely converting their stage.
@rymnc rymnc added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Oct 10, 2024
@xgreenx
Copy link
Collaborator

xgreenx commented Oct 11, 2024

We removed this method in the same PR=)

@xgreenx xgreenx closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Development

No branches or pull requests

2 participants