From 10c8a216e901061b6225f68811f5f8d82925b798 Mon Sep 17 00:00:00 2001
From: AurelienFT <aurelien.foucault@epitech.eu>
Date: Thu, 28 Nov 2024 11:50:44 +0100
Subject: [PATCH] Fix tests checks and clippy

---
 crates/services/sync/src/import/cache.rs | 20 ++++----------------
 crates/services/sync/src/import/tests.rs |  8 ++++----
 2 files changed, 8 insertions(+), 20 deletions(-)

diff --git a/crates/services/sync/src/import/cache.rs b/crates/services/sync/src/import/cache.rs
index 1503445bced..8717b5b21f3 100644
--- a/crates/services/sync/src/import/cache.rs
+++ b/crates/services/sync/src/import/cache.rs
@@ -140,14 +140,8 @@ impl Cache {
                     .into_iter()
                     .filter_map(|chunk| {
                         let (range, blocks): (Vec<u32>, Vec<SealedBlock>) = chunk.unzip();
-                        let Some(start_range) = range.get(0) else {
-                            return None;
-                        };
-                        let Some(mut end_range) =
-                            range.get(range.len().saturating_sub(1))
-                        else {
-                            return None;
-                        };
+                        let start_range = range.first()?;
+                        let mut end_range = range.get(range.len().saturating_sub(1))?;
                         Some(CachedDataBatch::Blocks(Batch::new(
                             None,
                             *start_range..end_range.saturating_add(1),
@@ -164,14 +158,8 @@ impl Cache {
                     .filter_map(|chunk| {
                         let (range, headers): (Vec<u32>, Vec<SealedBlockHeader>) =
                             chunk.unzip();
-                        let Some(start_range) = range.get(0) else {
-                            return None;
-                        };
-                        let Some(mut end_range) =
-                            range.get(range.len().saturating_sub(1))
-                        else {
-                            return None;
-                        };
+                        let start_range = range.first()?;
+                        let mut end_range = range.get(range.len().saturating_sub(1))?;
                         Some(CachedDataBatch::Headers(Batch::new(
                             None,
                             *start_range..end_range.saturating_add(1),
diff --git a/crates/services/sync/src/import/tests.rs b/crates/services/sync/src/import/tests.rs
index bfd8e8fc65a..baa4146a626 100644
--- a/crates/services/sync/src/import/tests.rs
+++ b/crates/services/sync/src/import/tests.rs
@@ -275,7 +275,7 @@ async fn import__keep_data_asked_in_fail_ask_header_cases() {
         .times(1)
         .in_sequence(&mut seq)
         .returning(|range| {
-            assert_eq!(range, 4..4);
+            assert_eq!(range, 4..5);
             Box::pin(async move {
                 tokio::time::sleep(Duration::from_millis(300)).await;
                 Err(anyhow::anyhow!("Some network error"))
@@ -299,7 +299,7 @@ async fn import__keep_data_asked_in_fail_ask_header_cases() {
         .times(1)
         .in_sequence(&mut seq)
         .returning(|range| {
-            assert_eq!(range, 4..4);
+            assert_eq!(range, 4..5);
             Box::pin(async move {
                 let peer = random_peer();
                 let headers = Some(range.map(empty_header).collect());
@@ -389,7 +389,7 @@ async fn import__keep_data_asked_in_fail_ask_transactions_cases() {
         .times(1)
         .in_sequence(&mut seq)
         .returning(|range| {
-            assert_eq!(range.data, 4..4);
+            assert_eq!(range.data, 4..5);
             Box::pin(async move {
                 tokio::time::sleep(Duration::from_millis(300)).await;
                 Err(anyhow::anyhow!("Some network error"))
@@ -413,7 +413,7 @@ async fn import__keep_data_asked_in_fail_ask_transactions_cases() {
         .times(1)
         .in_sequence(&mut seq)
         .returning(|block_ids| {
-            assert_eq!(block_ids, 4..4);
+            assert_eq!(block_ids, 4..5);
             Box::pin(async move {
                 let data = block_ids;
                 let v = data.into_iter().map(|_| Transactions::default()).collect();