Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some sub-package imports (ex: solid-js) not working #198

Closed
FredKSchott opened this issue Feb 13, 2020 · 1 comment
Closed

Some sub-package imports (ex: solid-js) not working #198

FredKSchott opened this issue Feb 13, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@FredKSchott
Copy link
Owner

Original Discussion: https://www.pika.dev/npm/snowpack/discuss/70
/cc @high1, @FredKSchott

// From the solid-js readme
import { render } from "solid-js/dom";
// This should work, but doesn't 
import { render } from "/web_modules/solid-js/dom.js";

It breaks because "node_modules/solid-js/dom" is a directory that only contains a package.json, that points to files back up in a different part of the package. It's the fact that this sub-package package.json specifically reaches up into its parent directory that breaks our resolver.

As a part of trying to figure out why exactly this was breaking, I think I found a good fix 😆PR incoming

@FredKSchott FredKSchott added the bug Something isn't working label Feb 13, 2020
@FredKSchott FredKSchott self-assigned this Feb 13, 2020
@FredKSchott
Copy link
Owner Author

Fixed in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant