Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Solidity version, eliminate external dependency on safeMath, and refactor arithmetic #239

Open
floor-licker opened this issue Dec 7, 2024 · 0 comments

Comments

@floor-licker
Copy link

I'd like to do this for the entire codebase. All .sol files would have their version updated to ^0.8.0 so that the external dependency on the safeMath library is eliminated, and the contracts will instead use the more robust and efficient built-in arithmetic of the 0.8.0 compiler. The main reason for doing this is gas efficiency, but also the only reason for using safeMath in older versions was for protection against overflow/underflow, but these checks are built-in to the Solidity compiler for versions >=0.8.0. If this update is approved I can submit the PR immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant