[valgrind] run tooling through CMake support (#232)

Author: FrancoisCarouge

.github/workflows/memory_valgrind.yml

@@ -12,39 +12,10 @@ jobs:
     steps:
     - name: Checkout
       uses: actions/checkout@v3.1.0
-    - name: Update
-      run: sudo apt update
     - name: Install
+      # Workaround to wg21 CMake installation issues.
       run: |
-        sudo apt install gcc-12 g++-12 valgrind
-        ( cd /tmp
-          git clone --depth 1 https://gitlab.com/libeigen/eigen.git
-          mkdir eigen/build
-          ( cd eigen/build
-            cmake ..
-            cmake --build . --parallel
-            sudo cmake --install . ) )
-        ( cd /tmp
-          git clone --depth 1 https://github.com/fmtlib/fmt.git
-          mkdir fmt/build
-          ( cd fmt/build
-            cmake ..
-            cmake --build . --parallel
-            sudo cmake --install . ) )
-        ( cd /tmp
-          git clone --depth 1 https://github.com/kokkos/mdspan.git
-          mkdir mdspan/build
-          ( cd mdspan/build
-            cmake ..
-            cmake --build . --parallel
-            sudo cmake --install . ) )
-        ( cd /tmp
-          git clone --depth 1 https://github.com/kokkos/stdBLAS.git
-          mkdir stdBLAS/build
-          ( cd stdBLAS/build
-            cmake ..
-            cmake --build . --parallel
-            sudo cmake --install . ) )
+        sudo apt install valgrind
         ( cd /tmp
           git clone --depth 1 https://github.com/BobSteagall/wg21.git
           mkdir wg21/build
@@ -53,9 +24,6 @@ jobs:
             sudo cmake --install . ) )
     - name: Build
       run: |
-        gcc-12 \
-          sample/*.cpp test/*.cpp source/*.cpp \
-          -Iinclude -I/usr/local/include/eigen3 -Isupport \
-          -g -O0 -std=c++23 -lstdc++ -lm -lfmt
-    - name: Test
-      run: valgrind --verbose ./a.out
+        cmake -B "build" .
+        cmake --build "build" --parallel 4
+        ctest --test-dir "build" --tests-regex "kalman_valgrind" --output-on-failure --parallel 4

sample/CMakeLists.txt

@@ -42,6 +42,10 @@ foreach(SAMPLE "kf_1x1x0_building_height.cpp" "kf_1x1x0_liquid_temperature.cpp"
   add_executable(kalman_sample_${NAME}_driver ${SAMPLE})
   target_link_libraries(kalman_sample_${NAME}_driver PRIVATE kalman main)
   add_test(kalman_sample_${NAME} kalman_sample_${NAME}_driver)
+  add_test(
+    NAME kalman_valgrind_${NAME}
+    COMMAND valgrind --error-exitcode=1 --leak-check=full --track-origins=yes
+            $<TARGET_FILE:kalman_sample_${NAME}_driver>)
 endforeach()
 
 foreach(SAMPLE_EIGEN
@@ -52,4 +56,8 @@ foreach(SAMPLE_EIGEN
   target_link_libraries(kalman_sample_eigen_${NAME}_driver PRIVATE Eigen3::Eigen
                                                                    kalman main)
   add_test(kalman_sample_eigen_${NAME} kalman_sample_eigen_${NAME}_driver)
+  add_test(
+    NAME kalman_valgrind_eigen_${NAME}
+    COMMAND valgrind --error-exitcode=1 --leak-check=full --track-origins=yes
+            $<TARGET_FILE:kalman_sample_eigen_${NAME}_driver>)
 endforeach()

test/CMakeLists.txt

@@ -41,6 +41,10 @@ foreach(TEST "f.cpp" "format.cpp" "h.cpp" "initialization.cpp")
   add_executable(kalman_test_${NAME}_driver ${TEST})
   target_link_libraries(kalman_test_${NAME}_driver PRIVATE kalman main)
   add_test(kalman_test_${NAME} kalman_test_${NAME}_driver)
+  add_test(
+    NAME kalman_valgrind_${NAME}
+    COMMAND valgrind --error-exitcode=1 --leak-check=full --track-origins=yes
+            $<TARGET_FILE:kalman_test_${NAME}_driver>)
 endforeach()
 
 foreach(TEST_EIGEN "eigen_f.cpp" "eigen_h.cpp" "eigen_initialization.cpp")
@@ -49,4 +53,8 @@ foreach(TEST_EIGEN "eigen_f.cpp" "eigen_h.cpp" "eigen_initialization.cpp")
   target_link_libraries(kalman_test_eigen_${NAME}_driver PRIVATE Eigen3::Eigen
                                                                  kalman main)
   add_test(kalman_test_eigen_${NAME} kalman_test_eigen_${NAME}_driver)
+  add_test(
+    NAME kalman_valgrind_eigen_${NAME}
+    COMMAND valgrind --error-exitcode=1 --leak-check=full --track-origins=yes
+            $<TARGET_FILE:kalman_test_eigen_${NAME}_driver>)
 endforeach()