Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal minimum dependencies versions? #82

Closed
Laura7089 opened this issue May 31, 2021 · 6 comments · Fixed by #91
Closed

Formal minimum dependencies versions? #82

Laura7089 opened this issue May 31, 2021 · 6 comments · Fixed by #91
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@Laura7089
Copy link
Member

I'm pretty sure the bot needs at least python 3.8, but I'm not too sure about that. We should formalise this.

@Laura7089 Laura7089 added bug Something isn't working documentation Improvements or additions to documentation labels May 31, 2021
@Laura7089
Copy link
Member Author

We probably also want to formalise the minimum versions of docker, docker-compose and postgres too while we're at it.

@Fluxticks
Copy link
Collaborator

Yeah the postgres one is an important one. I know that it definitely doesn't work on postgres 9, as I found that out the annoying way.

@Laura7089
Copy link
Member Author

These can just be as easy as looking at what versions we know work, decide if we think we should test older versions (if they're pre-release versions or whatever) then just adding a little "Minimum X Version: x.x.x" badge to the README, and version tags to docker-related files.

@Laura7089 Laura7089 changed the title Formal minimum python version? Formal minimum dependencies versions? Jun 1, 2021
@Fluxticks
Copy link
Collaborator

Not sure if this would come under the same issue, but there should also be a list of permissions the bot needs from discord, and we could even provide the unique code/id for that combination of permissions.

@Laura7089
Copy link
Member Author

Laura7089 commented Jun 3, 2021

Regarding software versions, we could probably just set them to the latest stable versions that we're using, ie:

Python 3.8+
Postgres 11+
Docker 20+
docker-compose version 1.25+

Unless anyone has objections, I'll open a pull request.

@Laura7089
Copy link
Member Author

Not sure if this would come under the same issue, but there should also be a list of permissions the bot needs from discord, and we could even provide the unique code/id for that combination of permissions.

Probably wants it's own issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants