Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MD5 hashing for ByteArray and RawFile objects #15

Open
FlyingJester opened this issue Nov 27, 2013 · 4 comments
Open

Implement MD5 hashing for ByteArray and RawFile objects #15

FlyingJester opened this issue Nov 27, 2013 · 4 comments

Comments

@FlyingJester
Copy link
Owner

MD5 hashing is not implemented for either the rawfile or bytearray object, even though TurboSphere ships with md5 reference libraries.

@Radnen
Copy link

Radnen commented Nov 30, 2013

Can you also add SHA-? MD5 is no good for encryption, and SHA barely gets by but at least it's slightly better. I've made the option an optional parameter in the hashing function, so that if you ran with normal Sphere 1.5 it'll always be MD5, but in your implementation it could be SHA-

@FlyingJester
Copy link
Owner Author

I certainly may, but that's sort of low priority. The MD5 feature of Sphere, I always thought, was more for fingerprinting than encryption.

@Radnen
Copy link

Radnen commented Dec 6, 2013

In fact Sphere is so old it was used for encryption! I even used it for encryption in an MMO tech demo, though I used a salt on the final string. I think the addition of SHA is not so bad if it's not too hard for you. For me, there was a good system library that had all manner of encryption algorithms in it.

@FlyingJester
Copy link
Owner Author

There are a lot of small, nicer SHA-1 and/or SHA-256/224 libraries with good licenses available for C++...I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants