Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object 3D Default up rotates edge selectors #19

Open
sam-thomas-dd opened this issue Dec 2, 2024 · 6 comments
Open

Object 3D Default up rotates edge selectors #19

sam-thomas-dd opened this issue Dec 2, 2024 · 6 comments

Comments

@sam-thomas-dd
Copy link

Hi! Thanks for the great library.

Just wanted to report that setting

THREE.Object3D.DEFAULT_UP = new THREE.Vector3(0, 0, 1);

Results in some of the edge selectors being incorrectly oriented

image
@sam-thomas-dd sam-thomas-dd changed the title Object 3D Default up rotates edge selestocs Object 3D Default up rotates edge selectors Dec 2, 2024
@Fennec-hub
Copy link
Owner

Thanks for pointing that out! I must ask, after setting the default up, is that the only side effect you're facing, is everything else working as expected?

@sam-thomas-dd
Copy link
Author

sam-thomas-dd commented Dec 9, 2024

I think the orientation may also be incorrect. Front is where I expect top to be but that could be a preference.

@seansackowitz
Copy link

Absolutely agree, it's a fantastic library!

The orientation is incorrect, but I was sort of able to fix this by changing the labels. When I click on Top though, the faces to the north and south are not Front and Back, but Right and Left.
image
Another much bigger issue is that clicking and dragging on the cube with Z-Up orientation is completely wonky and rotates quite unpredictably. Up and down mouse movement rotates the camera around the Z axis by a total of 180 degrees, and right and left rotates weirdly on both x and y axes simultaneously

@johanohly
Copy link

I am having the exact same problem as Sean, although I only do camera.up.set(0, 0, 1) to set the z-axis as up.

@KarlSimumatik
Copy link

I can confirm what Sean and Johan are saying. The function for rotating the camera when dragging the gizmo seems to only work with Y-axis up, any other axis up produces weird results. Clicking to rotate still works, at least in the default gizmo.

@Fennec-hub
Copy link
Owner

Hi! Thanks for your support and for reporting this issue.

The issue with the edge selectors has been fixed—they should now be correctly oriented. However, the gizmo still doesn’t fully handle Z-up (or any custom up direction different from the default) properly.

If anyone wants to contribute, your help is more than welcome! 🚀

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants