Skip to content

Commit 83cdfea

Browse files
authored
Add @NonNull annotations (#569)
1 parent bb20e3a commit 83cdfea

File tree

5 files changed

+14
-10
lines changed

5 files changed

+14
-10
lines changed

android/src/main/java/com/expensify/livemarkdown/MarkdownFormatter.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public MarkdownFormatter(@NonNull AssetManager assetManager) {
2020
mAssetManager = assetManager;
2121
}
2222

23-
public void format(SpannableStringBuilder ssb, List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
23+
public void format(@NonNull SpannableStringBuilder ssb, @NonNull List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
2424
try {
2525
Systrace.beginSection(0, "format");
2626
Objects.requireNonNull(markdownStyle, "mMarkdownStyle is null");
@@ -31,7 +31,7 @@ public void format(SpannableStringBuilder ssb, List<MarkdownRange> markdownRange
3131
}
3232
}
3333

34-
private void removeSpans(SpannableStringBuilder ssb) {
34+
private void removeSpans(@NonNull SpannableStringBuilder ssb) {
3535
try {
3636
Systrace.beginSection(0, "removeSpans");
3737
// We shouldn't use `removeSpans()` because it also removes SpellcheckSpan, SuggestionSpan etc.
@@ -44,7 +44,7 @@ private void removeSpans(SpannableStringBuilder ssb) {
4444
}
4545
}
4646

47-
private void applyRanges(SpannableStringBuilder ssb, List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
47+
private void applyRanges(@NonNull SpannableStringBuilder ssb, @NonNull List<MarkdownRange> markdownRanges, @NonNull MarkdownStyle markdownStyle) {
4848
try {
4949
Systrace.beginSection(0, "applyRanges");
5050
for (MarkdownRange markdownRange : markdownRanges) {
@@ -55,7 +55,7 @@ private void applyRanges(SpannableStringBuilder ssb, List<MarkdownRange> markdow
5555
}
5656
}
5757

58-
private void applyRange(SpannableStringBuilder ssb, MarkdownRange markdownRange, MarkdownStyle markdownStyle) {
58+
private void applyRange(@NonNull SpannableStringBuilder ssb, @NonNull MarkdownRange markdownRange, @NonNull MarkdownStyle markdownStyle) {
5959
String type = markdownRange.getType();
6060
int start = markdownRange.getStart();
6161
int end = start + markdownRange.getLength();
@@ -126,7 +126,7 @@ private void applyRange(SpannableStringBuilder ssb, MarkdownRange markdownRange,
126126
}
127127
}
128128

129-
private void setSpan(SpannableStringBuilder ssb, MarkdownSpan span, int start, int end) {
129+
private void setSpan(@NonNull SpannableStringBuilder ssb, @NonNull MarkdownSpan span, int start, int end) {
130130
ssb.setSpan(span, start, end, Spanned.SPAN_EXCLUSIVE_EXCLUSIVE);
131131
}
132132
}

android/src/main/java/com/expensify/livemarkdown/MarkdownParser.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ public MarkdownParser(@NonNull ReactContext reactContext) {
2929
mReactContext = reactContext;
3030
}
3131

32-
private native String nativeParse(String text, int parserId);
32+
private native String nativeParse(@NonNull String text, int parserId);
3333

34-
public synchronized List<MarkdownRange> parse(String text, int parserId) {
34+
public synchronized List<MarkdownRange> parse(@NonNull String text, int parserId) {
3535
try {
3636
Systrace.beginSection(0, "parse");
3737

android/src/main/java/com/expensify/livemarkdown/MarkdownRange.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package com.expensify.livemarkdown;
22

3+
import androidx.annotation.NonNull;
4+
35
public class MarkdownRange {
4-
private final String mType;
6+
private final @NonNull String mType;
57
private final int mStart;
68
private final int mLength;
79
private final int mDepth;
810

9-
public MarkdownRange(String type, int start, int length, int depth) {
11+
public MarkdownRange(@NonNull String type, int start, int length, int depth) {
1012
mType = type;
1113
mStart = start;
1214
mLength = length;

android/src/main/java/com/expensify/livemarkdown/MarkdownStyle.java

+2
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ public class MarkdownStyle {
3232

3333
private final float mBlockquotePaddingLeft;
3434

35+
@NonNull
3536
private final String mCodeFontFamily;
3637

3738
private final float mCodeFontSize;
@@ -42,6 +43,7 @@ public class MarkdownStyle {
4243
@ColorInt
4344
private final int mCodeBackgroundColor;
4445

46+
@NonNull
4547
private final String mPreFontFamily;
4648

4749
private final float mPreFontSize;

android/src/main/java/com/expensify/livemarkdown/MarkdownTextWatcher.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
import androidx.annotation.NonNull;
88

99
public class MarkdownTextWatcher implements TextWatcher {
10-
private final MarkdownUtils mMarkdownUtils;
10+
private final @NonNull MarkdownUtils mMarkdownUtils;
1111

1212
public MarkdownTextWatcher(@NonNull MarkdownUtils markdownUtils) {
1313
mMarkdownUtils = markdownUtils;

0 commit comments

Comments
 (0)