Remove old architecture support (#634)

Author: tomekzaw

.github/workflows/build-android.yml

@@ -26,12 +26,8 @@ jobs:
   build:
     if: github.repository == 'Expensify/react-native-live-markdown'
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        react-native-architecture: ['Paper', 'Fabric']
-      fail-fast: false
     concurrency:
-      group: build-android-${{ matrix.react-native-architecture }}-${{ github.ref }}
+      group: build-android-${{ github.ref }}
       cancel-in-progress: true
     steps:
       - name: Check out Git repository
@@ -48,4 +44,4 @@ jobs:
 
       - name: Build app
         working-directory: example/android
-        run: ./gradlew assembleDebug --build-cache -PreactNativeArchitectures=arm64-v8a -PnewArchEnabled=${{ matrix.react-native-architecture == 'Fabric' && 'true' || 'false' }}
+        run: ./gradlew assembleDebug --build-cache -PreactNativeArchitectures=arm64-v8a

.github/workflows/build-ios.yml

@@ -26,12 +26,8 @@ jobs:
   build:
     if: github.repository == 'Expensify/react-native-live-markdown'
     runs-on: macos-13
-    strategy:
-      matrix:
-        react-native-architecture: ['Paper', 'Fabric']
-      fail-fast: false
     concurrency:
-      group: build-ios-${{ matrix.react-native-architecture }}-${{ github.ref }}
+      group: build-ios-${{ github.ref }}
       cancel-in-progress: true
     steps:
       - name: Check out Git repository
@@ -43,8 +39,8 @@ jobs:
           path: |
             node_modules
             example/node_modules
-          key: build-ios-node-modules-${{ matrix.react-native-architecture }}-${{ hashFiles('package-lock.json') }}
-          restore-keys: build-ios-node-modules-${{ matrix.react-native-architecture }}-
+          key: build-ios-node-modules-${{ hashFiles('package-lock.json') }}
+          restore-keys: build-ios-node-modules-
 
       - name: Install node_modules
         run: npm ci
@@ -56,13 +52,11 @@ jobs:
             example/ios/Pods
             ~/Library/Caches/CocoaPods
             ~/.cocoapods
-          key: build-ios-pods-${{ matrix.react-native-architecture }}-${{ hashFiles('node_modules/react-native/package.json') }}
-          restore-keys: build-ios-pods-${{ matrix.react-native-architecture }}-
+          key: build-ios-pods-${{ hashFiles('node_modules/react-native/package.json') }}
+          restore-keys: build-ios-pods-
 
       - name: Install Pods
         working-directory: example/ios
-        env:
-          RCT_NEW_ARCH_ENABLED: ${{ matrix.react-native-architecture == 'Fabric' && '1' || '0' }}
         run: |
           bundler install
           bundler exec pod install
@@ -75,8 +69,8 @@ jobs:
         uses: actions/cache@v4
         with:
           path: ~/Library/Developer/Xcode/DerivedData
-          key: build-ios-derived-data-${{ matrix.react-native-architecture }}-${{ hashFiles('node_modules/react-native/package.json') }}
-          restore-keys: build-ios-derived-data-${{ matrix.react-native-architecture }}-
+          key: build-ios-derived-data-${{ hashFiles('node_modules/react-native/package.json') }}
+          restore-keys: build-ios-derived-data-
 
       - name: Build app
         working-directory: example

CONTRIBUTING.md

@@ -56,7 +56,7 @@ By default, the example is configured to build with the old architecture. To run
 2. For iOS, run:
 
    ```sh
-   cd example/ios && bundler install && RCT_NEW_ARCH_ENABLED=1 bundler exec pod install
+   cd example/ios && bundler install && bundler exec pod install
    npm run example ios
    ```
 

README.md

@@ -8,7 +8,7 @@
 - 🔧 Customizable logic
 - 🎨 Customizable styles
 - 🌐 Universal support (Android, iOS, web)
-- 🏗️ Supports New Architecture
+- 🏗️ Supports only the New Architecture
 
 ## Installation
 
@@ -179,7 +179,7 @@ Currently, `react-native-live-markdown` supports only [ExpensiMark](https://gith
 
 ## Compatibility
 
-`react-native-live-markdown` supports two latest React Native minor releases.
+`react-native-live-markdown` supports two latest React Native minor releases with the New Architecture enabled.
 
 | react-native | @expensify/react-native-live-markdown |
 | :----------: | :-----------------------------------: |

RNLiveMarkdown.podspec

@@ -36,18 +36,16 @@ Pod::Spec.new do |s|
 
   install_modules_dependencies(s)
 
-  if ENV['USE_FRAMEWORKS'] != nil && ENV['RCT_NEW_ARCH_ENABLED'] == '1'
+  if ENV['USE_FRAMEWORKS'] != nil
     add_dependency(s, "React-FabricComponents", :additional_framework_paths => [
       "react/renderer/textlayoutmanager/platform/ios",
       "react/renderer/components/textinput/platform/ios",
     ])
     add_dependency(s, "React-rendererconsistency")
   end
 
-  if ENV['RCT_NEW_ARCH_ENABLED'] == '1'
-    s.subspec "newarch" do |ss|
-      ss.source_files         = "cpp/**/*.{cpp,h}"
-      ss.header_dir           = "RNLiveMarkdown"
-    end
+  s.subspec "newarch" do |ss|
+    ss.source_files         = "cpp/**/*.{cpp,h}"
+    ss.header_dir           = "RNLiveMarkdown"
   end
 end

android/build.gradle

@@ -18,15 +18,8 @@ def reactNativeArchitectures() {
   return value ? value.split(",") : ["armeabi-v7a", "x86", "x86_64", "arm64-v8a"]
 }
 
-def isNewArchitectureEnabled() {
-  return rootProject.hasProperty("newArchEnabled") && rootProject.getProperty("newArchEnabled") == "true"
-}
-
 apply plugin: "com.android.library"
-
-if (isNewArchitectureEnabled()) {
-  apply plugin: "com.facebook.react"
-}
+apply plugin: "com.facebook.react"
 
 def getExtOrDefault(name) {
   return rootProject.ext.has(name) ? rootProject.ext.get(name) : project.properties["LiveMarkdown_" + name]
@@ -93,7 +86,6 @@ android {
     targetSdkVersion getExtOrIntegerDefault("targetSdkVersion")
 
     buildConfigField "int", "REACT_NATIVE_MINOR_VERSION", REACT_NATIVE_MINOR_VERSION.toString()
-    buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()
 
     consumerProguardFiles "proguard-rules.pro"
 
@@ -129,15 +121,10 @@ android {
 
   sourceSets {
     main {
-      if (isNewArchitectureEnabled()) {
-        java.srcDirs += [
-          "src/newarch",
-          // This is needed to build Kotlin project with NewArch enabled
-          "${project.buildDir}/generated/source/codegen/java"
-        ]
-      } else {
-        java.srcDirs += ["src/oldarch"]
-      }
+      java.srcDirs += [
+        // This is needed to build Kotlin project with NewArch enabled
+        "${project.buildDir}/generated/source/codegen/java"
+      ]
 
       // TextLayoutManager
       if (REACT_NATIVE_MINOR_VERSION <= 76 ) {
@@ -190,14 +177,6 @@ dependencies {
   implementation project(":react-native-reanimated")
 }
 
-if (isNewArchitectureEnabled()) {
-  react {
-    jsRootDir = file("../src/")
-    libraryName = "LiveMarkdown"
-    codegenJavaPackageName = "com.expensify.livemarkdown"
-  }
-}
-
 // This fixes linking errors due to undefined symbols from libworklets.so.
 // During Gradle Sync, Android Gradle Plugin runs Prefab and treats worklets
 // like a header-only library. During build, config files are not regenerated

android/src/main/java/com/expensify/livemarkdown/LiveMarkdownModule.java

@@ -22,11 +22,9 @@ public LiveMarkdownModule(ReactApplicationContext reactContext) {
 
   @Override
   public boolean install() {
-    if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
-      FabricUIManager uiManager =
-        (FabricUIManager) UIManagerHelper.getUIManager(getReactApplicationContext(), UIManagerType.FABRIC);
-      mNativeProxy.createCommitHook(uiManager);
-    }
+    FabricUIManager uiManager =
+      (FabricUIManager) UIManagerHelper.getUIManager(getReactApplicationContext(), UIManagerType.FABRIC);
+    mNativeProxy.createCommitHook(uiManager);
 
     long jsiRuntime = Objects.requireNonNull(getReactApplicationContext().getJavaScriptContextHolder(), "[react-native-live-markdown] JavaScriptContextHolder is null").get();
     injectJSIBindings(jsiRuntime);

android/src/newarch/LiveMarkdownModuleSpec.java android/src/main/java/com/expensify/livemarkdown/LiveMarkdownModuleSpec.java

@@ -1,16 +1,8 @@
-#ifdef RCT_NEW_ARCH_ENABLED
 #import <RNLiveMarkdownSpec/RNLiveMarkdownSpec.h>
-#else
-#import <React/RCTBridgeModule.h>
-#endif // RCT_NEW_ARCH_ENABLED
 
 #import <React/RCTEventEmitter.h>
 
 // Without inheriting after RCTEventEmitter we don't get access to bridge
-@interface LiveMarkdownModule : RCTEventEmitter
-#ifdef RCT_NEW_ARCH_ENABLED
-                                <NativeLiveMarkdownModuleSpec>
-#else
-                                <RCTBridgeModule>
-#endif // RCT_NEW_ARCH_ENABLED
+@interface LiveMarkdownModule : RCTEventEmitter <NativeLiveMarkdownModuleSpec>
+
 @end

android/src/newarch/MarkdownTextInputDecoratorViewManagerSpec.java android/src/main/java/com/expensify/livemarkdown/MarkdownTextInputDecoratorViewManagerSpec.java

@@ -1,17 +1,11 @@
 #import "LiveMarkdownModule.h"
 
 #import <RNLiveMarkdown/RuntimeDecorator.h>
-
-#ifdef RCT_NEW_ARCH_ENABLED
 #import <RNLiveMarkdown/MarkdownCommitHook.h>
-#endif // RCT_NEW_ARCH_ENABLED
 
 #import <React/RCTBridge+Private.h>
-
-#ifdef RCT_NEW_ARCH_ENABLED
 #import <React/RCTScheduler.h>
 #import <React/RCTSurfacePresenter.h>
-#endif // RCT_NEW_ARCH_ENABLED
 
 #import <jsi/jsi.h>
 
@@ -23,10 +17,8 @@
 // actually register the hook
 
 @implementation LiveMarkdownModule {
-#ifdef RCT_NEW_ARCH_ENABLED
   std::shared_ptr<MarkdownCommitHook> commitHook_;
   __weak RCTSurfacePresenter *surfacePresenter_;
-#endif // RCT_NEW_ARCH_ENABLED
 }
 
 RCT_EXPORT_MODULE()
@@ -37,16 +29,12 @@ @implementation LiveMarkdownModule {
   jsi::Runtime &rt = *(jsi::Runtime *)cxxBridge.runtime;
   expensify::livemarkdown::injectJSIBindings(rt);
 
-#ifdef RCT_NEW_ARCH_ENABLED
   RCTScheduler *scheduler = [surfacePresenter_ scheduler];
   commitHook_ = std::make_shared<MarkdownCommitHook>(scheduler.uiManager);
-#endif // RCT_NEW_ARCH_ENABLED
 
   return @(1);
 }
 
-#ifdef RCT_NEW_ARCH_ENABLED
-
 - (void)handleJavaScriptDidLoadNotification:(NSNotification *)notification
 {
   surfacePresenter_ = self.bridge.surfacePresenter;
@@ -89,6 +77,4 @@ - (void)invalidate {
   [super invalidate];
 }
 
-#endif // RCT_NEW_ARCH_ENABLED
-
 @end

android/src/newarch/NativeProxy.java android/src/main/java/com/expensify/livemarkdown/NativeProxy.java

@@ -1,5 +1,4 @@
 #pragma once
-#ifdef RCT_NEW_ARCH_ENABLED
 
 #include <react/renderer/components/iostextinput/TextInputShadowNode.h>
 #include <react/renderer/uimanager/UIManager.h>
@@ -45,5 +44,3 @@ class MarkdownCommitHook : public UIManagerCommitHook {
 
 } // namespace livemarkdown
 } // namespace expensify
-
-#endif // RCT_NEW_ARCH_ENABLED

android/src/oldarch/LiveMarkdownModuleSpec.java

@@ -1,5 +1,3 @@
-#ifdef RCT_NEW_ARCH_ENABLED
-
 #include <React/RCTUtils.h>
 #include <react/renderer/core/ComponentDescriptor.h>
 #include <react/renderer/textlayoutmanager/RCTAttributedTextUtils.h>
@@ -303,5 +301,3 @@
 
 } // namespace livemarkdown
 } // namespace expensify
-
-#endif // RCT_NEW_ARCH_ENABLED

android/src/oldarch/MarkdownTextInputDecoratorViewManagerSpec.java

@@ -1,5 +1,3 @@
-// This guard prevent this file to be compiled in the old architecture.
-#ifdef RCT_NEW_ARCH_ENABLED
 #import <React/RCTViewComponentView.h>
 
 NS_ASSUME_NONNULL_BEGIN
@@ -8,5 +6,3 @@ NS_ASSUME_NONNULL_BEGIN
 @end
 
 NS_ASSUME_NONNULL_END
-
-#endif /* RCT_NEW_ARCH_ENABLED */

android/src/oldarch/NativeLiveMarkdownModuleSpec.java

@@ -1,5 +1,3 @@
-// This guard prevent this file to be compiled in the old architecture.
-#ifdef RCT_NEW_ARCH_ENABLED
 #import <react/renderer/components/RNLiveMarkdownSpec/Props.h>
 
 #import <RNLiveMarkdown/MarkdownTextInputDecoratorComponentView.h>
@@ -85,4 +83,3 @@ - (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &
 }
 
 @end
-#endif