From 72113b4295d5881adf612dcefbb68af5874f7c34 Mon Sep 17 00:00:00 2001 From: Dylan Date: Wed, 15 Nov 2023 11:00:18 +0700 Subject: [PATCH 1/2] using SET to save updated transaction --- src/libs/actions/IOU.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/actions/IOU.js b/src/libs/actions/IOU.js index aa07f0e7ca34..d3fa2f4915ba 100644 --- a/src/libs/actions/IOU.js +++ b/src/libs/actions/IOU.js @@ -765,7 +765,7 @@ function updateDistanceRequest(transactionID, transactionThreadReportID, transac // Optimistically modify the transaction optimisticData.push({ - onyxMethod: Onyx.METHOD.MERGE, + onyxMethod: Onyx.METHOD.SET, key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, value: { ...updatedTransaction, From 88ebfd8035ffb0f3a0fbced5589aef56fb01d4b6 Mon Sep 17 00:00:00 2001 From: Dylan Date: Thu, 30 Nov 2023 12:28:11 +0700 Subject: [PATCH 2/2] add comment --- src/libs/actions/IOU.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libs/actions/IOU.js b/src/libs/actions/IOU.js index d3fa2f4915ba..a14358fc0582 100644 --- a/src/libs/actions/IOU.js +++ b/src/libs/actions/IOU.js @@ -765,6 +765,7 @@ function updateDistanceRequest(transactionID, transactionThreadReportID, transac // Optimistically modify the transaction optimisticData.push({ + // We need to use SET method to save updated waypoint instead MERGE method to avoid wrong update of waypoints. More detail: https://github.com/Expensify/App/issues/30290#issuecomment-1778957070 onyxMethod: Onyx.METHOD.SET, key: `${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`, value: {