diff --git a/.github/actions/javascript/contributorChecklist/contributorChecklist.js b/.github/actions/javascript/contributorChecklist/contributorChecklist.js index 62036078d24c..552e1c374071 100644 --- a/.github/actions/javascript/contributorChecklist/contributorChecklist.js +++ b/.github/actions/javascript/contributorChecklist/contributorChecklist.js @@ -65,7 +65,7 @@ const completedContributorPlusChecklist = `- [x] I have verified the author chec - [x] Android / Chrome - [x] MacOS / Chrome - [x] MacOS / Desktop -- [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) +- [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack - [x] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. \`toggleReport\` and not \`onIconClick\`). - [x] I verified that comments were added to code that is not self explanatory diff --git a/.github/actions/javascript/contributorChecklist/index.js b/.github/actions/javascript/contributorChecklist/index.js index 1041b6906cfd..94d6cf8e0829 100644 --- a/.github/actions/javascript/contributorChecklist/index.js +++ b/.github/actions/javascript/contributorChecklist/index.js @@ -75,7 +75,7 @@ const completedContributorPlusChecklist = `- [x] I have verified the author chec - [x] Android / Chrome - [x] MacOS / Chrome - [x] MacOS / Desktop -- [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) +- [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack - [x] I verified proper code patterns were followed (see [Reviewing the code](https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code)) - [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. \`toggleReport\` and not \`onIconClick\`). - [x] I verified that comments were added to code that is not self explanatory