Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: move the is-typing and you-appear-offline up above the compose field #9087

Closed
mvtglobally opened this issue May 19, 2022 · 2 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to app with account A
  2. From account B on another device/browser, start typing
  3. Set yourself offline

Expected Result:

The is-typing and you-appear-offline should appear above the compose field with the time data

Actual Result:

"Person is typing..." and you-appear-offline message appear appear at the bottom space

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.63-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image - 2022-05-19T004927 188

related to #9086
Expensify/Expensify Issue URL:
Issue reported by: @rafecolton
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1652907024304559?thread_ts=1652905715.417509&cid=C01GTK53T8Q

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 NewFeature Something to build that is a new item. labels May 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 19, 2022

Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label May 19, 2022
@tgolen tgolen assigned tgolen and unassigned kadiealexander May 19, 2022
@tgolen tgolen added Weekly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels May 19, 2022
@tgolen
Copy link
Contributor

tgolen commented May 19, 2022

I'm going to work on this one internally.

@tgolen tgolen added Engineering Reviewing Has a PR in review and removed NewFeature Something to build that is a new item. labels May 19, 2022
@melvin-bot melvin-bot bot closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants