Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-05-17 #9053

Closed
6 tasks done
OSBotify opened this issue May 17, 2022 · 7 comments
Closed
6 tasks done

Deploy Checklist: New Expensify 2022-05-17 #9053

OSBotify opened this issue May 17, 2022 · 7 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 17, 2022

Release Version: 1.1.62-0
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 17, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.62-0 🚀

@mvtglobally
Copy link

Regression is completed
No Deploy Blockers

Issues found
#9057
#9058
#9061

@roryabraham
Copy link
Contributor

I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.

Actually there is a noticeable spike in both homepage reports loaded and switch report. Going to check this off on this checklist, because:

  • The spike was most poignant on Android, and none of these PRs affect the Android app.
  • There was another deploy earlier today which was more likely the source of any performance regressions than this one

@roryabraham
Copy link
Contributor

:shipit:

@roryabraham
Copy link
Contributor

Due to GitHub API errors, this failed to deploy. Reopening for now.

@AndrewGable
Copy link
Contributor

:shipit:

@SumitDiyora
Copy link

SumitDiyora commented May 23, 2022

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PR -#9033
Logged Issues - #8479, #8478, #8480, #8429, #8624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants