Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOS - Can't play videos or download videos in any format #8923

Closed
kbecciv opened this issue May 10, 2022 · 11 comments
Closed

IOS - Can't play videos or download videos in any format #8923

kbecciv opened this issue May 10, 2022 · 11 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented May 10, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing PR: #7849

Action Performed:

  1. Open App
  2. Login any user in which you have videos upload
  3. Go to any chat with the video attachment on the iOS native app
  4. Click on the download icon on the right of the attachment view

Expected Result:

The preview of the video should be shown and you can download it

Actual Result:

The video preview is not shown and cannot be downloaded

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.57.12

Reproducible in staging?: Yes

Reproducible in production?: No/Yes (in production the preview of the video is not shown but it can be downloaded)

Email or phone of affected tester (no customers): utester29+1@gmail.com/Epa12345678

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5566085_Pr_7849-1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 10, 2022

Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Justicea83 Justicea83 assigned Justicea83 and unassigned Justicea83 May 11, 2022
@Justicea83
Copy link
Contributor

Can we make this an external issue?

@Justicea83 Justicea83 added the External Added to denote the issue can be worked on by a contributor label May 11, 2022
@Justicea83 Justicea83 removed their assignment May 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2022

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@thienlnam
Copy link
Contributor

I believe this was also a regression from #7909, I have a revert up for it here: #7909

@thienlnam thienlnam removed the External Added to denote the issue can be worked on by a contributor label May 12, 2022
@melvin-bot melvin-bot bot added the Overdue label May 16, 2022
@thienlnam
Copy link
Contributor

thienlnam commented May 16, 2022

Is this still reproducible @kbecciv? The fix is on production

@melvin-bot melvin-bot bot removed the Overdue label May 16, 2022
@kbecciv
Copy link
Author

kbecciv commented May 19, 2022

@thienlnam Yes. Issue is still reproduced on last QA Regression.

@melvin-bot melvin-bot bot added the Overdue label May 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 20, 2022

@thienlnam Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2022

@thienlnam 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@thienlnam
Copy link
Contributor

Back from OOO, will look into this later today

@melvin-bot melvin-bot bot removed the Overdue label May 25, 2022
@thienlnam
Copy link
Contributor

I don't think we ever had the functionality to view videos inside the app / it always needed to be downloaded. Going to close this since it works as expected now (shows as attachment and can be downloaded)

@mallenexpensify
Copy link
Contributor

We have this issue
#7835
I imagine that's cover iOS too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants