Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHN - the workspace chat in the left hand navigation isn't appeared for public account (gmail) #8728

Closed
kbecciv opened this issue Apr 21, 2022 · 7 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Apr 21, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing PR: #8476

Action Performed:

Precondition: Create new public account (Gmail)

  1. Launch App and login
  2. Create a new workspace.

Expected Result:

Verify that you immediately see the workspace chat in the left hand navigation

Actual Result:

The workspace chat in the left hand navigation isn't appeared.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.56.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): rybkina+4202022@gmail.com/Qwerty123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5540759_New_Desktop.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 21, 2022

Triggered auto assignment to @amyevans (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@amyevans
Copy link
Contributor

I haven't been able to reproduce this issue. I am on the 1.1.56-0 branch and I also tested on main.

Video:

app-issue-8728-480.mov

@kbecciv do you think perhaps it's just that you were in Focus mode instead of Most Recent? The new workspace doesn't have any unread messages, nor is it pinned, so in Focus mode I think it's expected that the workspace wouldn't show in the LHN. Let me know if I'm misunderstanding though!

@mvtglobally
Copy link

@amyevans, We are not able to repro this issue with the expensifail accounts. It is only repro with Gmail(public domain). It is not related to focus mode.

@melvin-bot melvin-bot bot added the Overdue label Apr 25, 2022
@amyevans
Copy link
Contributor

Okay, I'll take another stab at reproducing, this time production instead of local and see where that lands me.

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2022
@francoisl
Copy link
Contributor

cc'ing @TomatoToaster as per the QA steps in the PR:

No failure case needed since this is in beta, if this is not working let @TomatoToaster know so it can be fixed in a followup PR

@amyevans
Copy link
Contributor

Good eye @francoisl, thanks for catching that!

@TomatoToaster
Copy link
Contributor

Precondition: Create new public account (Gmail)

  1. Launch App and login
  2. Create a new workspace.

The workspace chat feature is in beta. Public account users should NOT be seeing workspace chats so I'd say this is working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants