Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Message - Sent offline messages after reconnecting isn't appeared. #8690

Closed
kbecciv opened this issue Apr 19, 2022 · 15 comments
Closed
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Apr 19, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Precondition: Log in with Device A in IOS app
Log in with Device B in Web/Mac

  1. Disable your internet connection in device A.
  2. Send some messages, while offline, to another account (account B) you have access
  3. Enable the internet connection in device A.

Expected Result:

Sent offline messages after reconnecting is appeared.

Actual Result:

Sent offline messages after reconnecting isn't appeared.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web/ Mac
  • Mobile Web

Version Number: 1.1.55.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): rybkina@gmail.com/Qwerty123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5538729_iOS_offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 19, 2022

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@timszot timszot removed their assignment Apr 19, 2022
@timszot timszot added the External Added to denote the issue can be worked on by a contributor label Apr 19, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 19, 2022

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@trjExpensify
Copy link
Contributor

Ah, interesting! @tgolen @marcaaron is this an issue that should go on hold until the offline initiative is implemented?

@tgolen
Copy link
Contributor

tgolen commented Apr 19, 2022

Yep!

@marcaaron
Copy link
Contributor

There's no clear reason why this shouldn't work today. Is it consistently reproducible @kbecciv? It looks like this is being reported as affecting "all platforms", but offline messages are working fine for me on the web version of the app. Maybe we can look at logs and see what happened with this request.

@kbecciv
Copy link
Author

kbecciv commented Apr 20, 2022

@marcaaron QA tester was consistently reproduced the issue in MAC with IOS app. We can make another combination of testing if needed, please let me know. Thank you

@kbecciv
Copy link
Author

kbecciv commented Apr 21, 2022

Issue reproduced with combination Win/Chrome and IOS/safari

messege.2104.mp4

@marcaaron
Copy link
Contributor

Can we please update the description to say which platforms specifically are affected?

@melvin-bot melvin-bot bot added the Overdue label Apr 21, 2022
@kbecciv kbecciv changed the title Web/Mac - Message - Sent offline messages after reconnecting isn't appeared. Web - Message - Sent offline messages after reconnecting isn't appeared. Apr 21, 2022
@kbecciv
Copy link
Author

kbecciv commented Apr 21, 2022

@marcaaron Updated affected platforms.

@melvin-bot
Copy link

melvin-bot bot commented Apr 22, 2022

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Apr 22, 2022

@trjExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@trjExpensify
Copy link
Contributor

Alrighty, so it sounds like we do want to move this on to Upwork then?

@melvin-bot melvin-bot bot removed the Overdue label Apr 25, 2022
@marcaaron
Copy link
Contributor

marcaaron commented Apr 25, 2022

I am a little confused by this issue. Title says "sent offline messages after reconnecting isn't appeared".

That implies a user is sending messages while offline. But I think what this is really asking for is something like...

Chat not syncing with most recent comments when user comes back from offline

Does everyone agree with that?

@marcaaron
Copy link
Contributor

We are only fetching the report history once here -

Report.fetchActions(this.props.reportID);

This should be solved as part of the Network Improvements doc. I will just grab this actually.

@marcaaron marcaaron added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor labels Apr 25, 2022
@marcaaron marcaaron self-assigned this Apr 25, 2022
@trjExpensify
Copy link
Contributor

This should be solved as part of the Network Improvements doc. I will just grab this actually.

Hurrah for offline first! Okay, so this was reported by Applause and it's staying internal, so I'll go ahead and unassign myself as the CM.

@trjExpensify trjExpensify removed their assignment Apr 25, 2022
@melvin-bot melvin-bot bot added the Overdue label Apr 27, 2022
@marcaaron marcaaron added the Reviewing Has a PR in review label Apr 27, 2022
@melvin-bot melvin-bot bot removed the Overdue label Apr 27, 2022
@melvin-bot melvin-bot bot closed this as completed Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants