-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Add a download button to the context menu for attachments. #8588
Comments
Triggered auto assignment to @sophiepintoraetz ( |
Triggered auto assignment to @techievivek ( |
Seems like a good feature to add to New Expensify. We would also need help from the Design team to get the look right. |
Triggered auto assignment to @megankelso ( |
wouldn't it be convenient if we have just over the image, just like how we have in Slack? |
@megankelso But I think your suggestion wilL provide a consistent UI and also be easy to implement. So let's take a call on one of these and I will move forward with implementing it. |
cc @Expensify/design for thoughts but I think this would be the correct way to add this feature into our existing UI |
good point, this wouldn't work for multiple images in a message |
Ok cool thanks for all the inputs, I will start working on it now. 🙌 |
not overdue! any updates here? |
Interesting yeah I agree that the comment action menu feels like the right place for now. That said, I also have one request: If would be great to pull these kinds of platform decisions out of Github and into Slack. I'd highly recommend posting in #expensify-open-source and then reposting in #product so we get ample feedback from both the community as well as Expensify employees. |
Sure @JmillsExpensify will keep that in mind going forward. And will push a PR today itself. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Problem:
It’s hard to locate the download button, and it’s a two step process (open attachment -> click download).
Solution:
Add a download attachment button to the context menu.
Action Performed:
Expected Result:
User should see download icon in chat
Actual Result:
User has to click on the file to open it before locating download button
Workaround:
unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.54-0

Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @joaniew
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649278748377769
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: