Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add a download button to the context menu for attachments. #8588

Closed
mvtglobally opened this issue Apr 11, 2022 · 14 comments
Closed
Assignees
Labels
Design Engineering Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@mvtglobally
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem:

It’s hard to locate the download button, and it’s a two step process (open attachment -> click download).

Solution:

Add a download attachment button to the context menu.

Action Performed:

  1. Open any chat
  2. Send few attachments
  3. Try to download attachment sent

Expected Result:

User should see download icon in chat

Actual Result:

User has to click on the file to open it before locating download button

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.54-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen Shot 2022-04-11 at 1 11 04 AM

Expensify/Expensify Issue URL:
Issue reported by: @joaniew
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649278748377769

View all open jobs on GitHub

@mvtglobally mvtglobally added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 NewFeature Something to build that is a new item. labels Apr 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 11, 2022

Triggered auto assignment to @sophiepintoraetz (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Apr 11, 2022
@sophiepintoraetz sophiepintoraetz added Engineering Weekly KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 labels Apr 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 11, 2022

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sophiepintoraetz sophiepintoraetz removed their assignment Apr 11, 2022
@techievivek
Copy link
Contributor

techievivek commented Apr 11, 2022

Seems like a good feature to add to New Expensify. We would also need help from the Design team to get the look right.

@melvin-bot
Copy link

melvin-bot bot commented Apr 11, 2022

Triggered auto assignment to @megankelso (Design), see these Stack Overflow questions for more details.

@megankelso
Copy link

Perhaps we just add the download button to our current hover design for attachments?

dnload

@techievivek
Copy link
Contributor

wouldn't it be convenient if we have just over the image, just like how we have in Slack?

@techievivek
Copy link
Contributor

@megankelso But I think your suggestion wilL provide a consistent UI and also be easy to implement. So let's take a call on one of these and I will move forward with implementing it.

@megankelso
Copy link

cc @Expensify/design for thoughts but I think this would be the correct way to add this feature into our existing UI

@shawnborton
Copy link
Contributor

Interesting, I can see both sides of this.

Slack does this where you just hover over an image:
image

And I think that makes sense because with Slack, you could have a message that has multiple images attached to it.

For Expensify though, I believe we currently only show one image per message in all cases. So I actually think what Megan has mocked up makes sense for the v1 of this feature (it seems like the most consistent and easiest thing to implement) until we start to support multiple images per message in the future.

@megankelso
Copy link

good point, this wouldn't work for multiple images in a message

@techievivek
Copy link
Contributor

Ok cool thanks for all the inputs, I will start working on it now. 🙌

@melvin-bot melvin-bot bot added the Overdue label Apr 20, 2022
@megankelso
Copy link

not overdue! any updates here?

@melvin-bot melvin-bot bot removed the Overdue label Apr 20, 2022
@JmillsExpensify
Copy link

Interesting yeah I agree that the comment action menu feels like the right place for now.

That said, I also have one request: If would be great to pull these kinds of platform decisions out of Github and into Slack. I'd highly recommend posting in #expensify-open-source and then reposting in #product so we get ample feedback from both the community as well as Expensify employees.

@techievivek
Copy link
Contributor

Sure @JmillsExpensify will keep that in mind going forward. And will push a PR today itself.

@techievivek techievivek added the Reviewing Has a PR in review label Apr 21, 2022
@melvin-bot melvin-bot bot closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Engineering Improvement Item broken or needs improvement. NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants