Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[$500] New Group - Default icon displayed after creating a Group Chat #8573

Closed
kbecciv opened this issue Apr 9, 2022 · 27 comments
Closed

[$500] New Group - Default icon displayed after creating a Group Chat #8573

kbecciv opened this issue Apr 9, 2022 · 27 comments
Assignees
@iwiznia @mananjadhav @mallenexpensify
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Apr 9, 2022 •
edited
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to https://staging.new.expensify.com
  2. Log in with expensifail account
  3. Tap on Fub menu - Select New Group
  4. Select a few users and tap Create Group

Expected Result:

User icons displayed when creating Group Chat

Actual Result:

Default icon displayed after creating a Group Chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Desktop App

Version Number: 1.1.54.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+033122abb@applause.expensifail.com

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5525860_Screen_Recording_20220406-101439_New_Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub
@melvin-bot
Copy link

melvin-bot bot commented Apr 9, 2022

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mvtglobally mvtglobally mentioned this issue Apr 11, 2022
Closed
17 tasks
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2022
@bondydaa
Copy link
Contributor

the expected result and actual result are the same in the OP.

I'm not familiar enough to know which icon should be shown so if we know which icon it is can we make sure it's stated which one? pretty sure this is external.

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2022
@bondydaa bondydaa removed their assignment Apr 11, 2022
@bondydaa bondydaa added the External Added to denote the issue can be worked on by a contributor label Apr 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 11, 2022

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@mallenexpensify
Copy link
Contributor

@kbecciv, the actual and expected are the same in the OP, can you update please? I'll post the job after.

@kbecciv
Copy link
Author

kbecciv commented Apr 11, 2022

@mallenexpensify Sorry about that, updated!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 12, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 12, 2022

Triggered auto assignment to @mountiny (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title New Group - Default icon displayed after creating a Group Chat [$250] New Group - Default icon displayed after creating a Group Chat Apr 12, 2022
@mallenexpensify
Copy link
Contributor

Thanks @kbecciv !
Job posted https://www.upwork.com/jobs/~01139053e67fc42e9e

@mountiny
Copy link
Contributor

@kbecciv Do you have an illustration/mock up of how it should look like? I assume you should have if that is a QA step, but otherwise we can ask the design team.

@rushatgabhane
Copy link
Member

rushatgabhane commented Apr 12, 2022 •
edited
Loading

LHN icon for two users
image

LHN icon for more than two users
image

Report welcome message
image

@mountiny I'm sure it should look like the group icons we already have.

I remember this used to work as expected before. Is this a regression?

@mountiny
Copy link
Contributor

Just good to show this to contributors, who should work on it.

Feels like this is a regression, however, from a previous versions as the issue suggests this is already in production.

A good hint to look into the previous PRs which most likely caused this.

@mountiny mountiny removed their assignment Apr 14, 2022
@mallenexpensify mallenexpensify changed the title [$250] New Group - Default icon displayed after creating a Group Chat [$500] New Group - Default icon displayed after creating a Group Chat Apr 20, 2022
@rushatgabhane
Copy link
Member

@Expensify/contributor-plus wanna pick this up? I'll be OOO because school exams 📖👨‍🏫
No proposals yet

@rushatgabhane rushatgabhane removed their assignment Apr 26, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Current assignee @iwiznia is eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Apr 26, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot
Copy link

melvin-bot bot commented Apr 26, 2022

Current assignee @iwiznia is eligible for the Exported assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 27, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 27, 2022

📣 @mananjadhav You have been assigned to this job by @michaelhaxhiu!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@michaelhaxhiu michaelhaxhiu added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 27, 2022
@mananjadhav
Copy link
Collaborator

Waiting for proposals.

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mallenexpensify
Copy link
Contributor

Going to wait to double since @mvtglobally wasn't able to reproduce. I just tried on web and wasn't able to reproduce (web wasn't mentioned in the list of platforms though...)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mananjadhav
Copy link
Collaborator

@mallenexpensify Are we good to close this? Second week and issue not reproducible.

@michaelhaxhiu
Copy link
Contributor

Good call, let's close @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iwiznia iwiznia

@mananjadhav mananjadhav

@mallenexpensify mallenexpensify

Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@iwiznia @mananjadhav @bondydaa @michaelhaxhiu @mallenexpensify @parasharrajat @rushatgabhane @mountiny @mvtglobally @kbecciv