Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2022-09-07] [$250] Android/iOS - "Connect to bank" transition is not smooth and can see previous details reported by @thesahindia #8541

Closed
kbecciv opened this issue Apr 7, 2022 · 75 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Apr 7, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

Pre-Condition: Have a workspace created

  1. Open the New Expensify app on iOS
  2. Sign into an applause.expensify.com account
  3. Tap on the "Profile" icon
  4. Tap on the workspace
  5. Tap on any tab that has "Connect to bank" (For example: Issue cards, reimburse expenses, etc)
  6. Tap on "Connect bank account"

Expected Result:

The user expects a smooth transition when tapping on "Connect bank account"

Actual Result:

When tapping on this link, the transaction shows momentarily information from the previous page

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.52.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): n/a

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5523734_Connect_bank_account.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause / @thesahindia

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649070836326089

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Apr 7, 2022

Triggered auto assignment to @timszot (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@timszot timszot removed their assignment Apr 7, 2022
@timszot timszot added the External Added to denote the issue can be worked on by a contributor label Apr 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 7, 2022

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@thesahindia
Copy link
Member

Is this eligible for the reporting bonus as I had reported it on slack

Also here's a slowed down video -

video_20220404_162422_edit.1.mp4

@laurenreidexpensify laurenreidexpensify changed the title Andriod/iOS - "Connect to bank" transition is not smooth and can see previous details Android/iOS - "Connect to bank" transition is not smooth and can see previous details Apr 8, 2022
@laurenreidexpensify laurenreidexpensify changed the title Android/iOS - "Connect to bank" transition is not smooth and can see previous details Android/iOS - "Connect to bank" transition is not smooth and can see previous details reported by @thesahindia Apr 8, 2022
@laurenreidexpensify

This comment was marked as outdated.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title Android/iOS - "Connect to bank" transition is not smooth and can see previous details reported by @thesahindia [$250] Android/iOS - "Connect to bank" transition is not smooth and can see previous details reported by @thesahindia Apr 8, 2022
@laurenreidexpensify laurenreidexpensify removed the External Added to denote the issue can be worked on by a contributor label Apr 8, 2022
@laurenreidexpensify laurenreidexpensify added the External Added to denote the issue can be worked on by a contributor label Apr 8, 2022
@melvin-bot
Copy link

melvin-bot bot commented Apr 8, 2022

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Apr 8, 2022
@parasharrajat
Copy link
Member

parasharrajat commented Aug 11, 2022

@dharmik Will, you be able to provide an update on the progress? We are really looking to close this. If you are not able to work on the requested changes, I will unassign you and complete the PR myself ⏲️

@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2022
@puneetlath
Copy link
Contributor

Looks like we've had some progress on the PR. Are we getting closer?

@melvin-bot
Copy link

melvin-bot bot commented Aug 23, 2022

@iwiznia, @puneetlath, @dharmik, @parasharrajat 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@puneetlath
Copy link
Contributor

Looks like the PR is getting closer. Let's try to get this over the finish line asap. It has been dragging for a long time.

@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2022

@iwiznia, @puneetlath, @dharmik, @parasharrajat Eep! 4 days overdue now. Issues have feelings too...

@puneetlath
Copy link
Contributor

It has been C+ approved, so we're finally getting closer.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 labels Aug 29, 2022
@melvin-bot
Copy link

melvin-bot bot commented Aug 31, 2022

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.94-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2022-09-07. 🎊

@melvin-bot melvin-bot bot changed the title [$250] Android/iOS - "Connect to bank" transition is not smooth and can see previous details reported by @thesahindia [HOLD for payment 2022-09-07] [$250] Android/iOS - "Connect to bank" transition is not smooth and can see previous details reported by @thesahindia Aug 31, 2022
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 7, 2022
@puneetlath
Copy link
Contributor

@parasharrajat @thesahindia @dharmik sent you all hiring offers in Upwork.

@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2022

@iwiznia, @puneetlath, @dharmik, @parasharrajat Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Sep 12, 2022

Not overdue

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2022
@puneetlath
Copy link
Contributor

@dharmik can you please accept the Upwork offer so that we can pay you out and close this issue.

@dharmik
Copy link
Contributor

dharmik commented Sep 13, 2022

@puneetlath Accepted.

@puneetlath
Copy link
Contributor

All paid! Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests