Console Error when UpArrow is pressed in emoji picker - reported by @sobitneupane

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Emoji Picker.
2. Press down arrow to highlight emoji.
3. Now Press UpArrow

Expected Result:

there should be no console errors

Actual Result:

Console error when press UP

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.46-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-03-24.at.17.22.16.mov

Expensify/Expensify Issue URL:
Issue reported by: @sobitneupane
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648122317605959

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @NicMendonca (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[sobitneupane]

Solution:
Proposing solution early as I reported this issue.
As the error statement suggests, error is occuring in following code segment. Addition of the following lines of code will solve the issue.

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 256 to 259 in 6e9d429

	const isHeader = e => e.header || e.spacer;
	do {
	newIndex += steps;
	} while (isHeader(this.state.filteredEmojis[newIndex]));

           do {
               newIndex += steps;
+               if (newIndex < 0) {
+                   break;
+               }
           } while (isHeader(this.state.filteredEmojis[newIndex]));
       };

[melvin-bot]

Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@Justicea83 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@Justicea83 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@Justicea83 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@Justicea83 10 days overdue. Is anyone even seeing these? Hello?

[sobitneupane]

Hello @Justicea83 @NicMendonca, Looks like code was deployed to production 9 days ago. Waiting for my payment.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[NicMendonca]

@sobitneupane sorry! Can you please apply for the job so we can issue payment: https://www.upwork.com/jobs/~018897a01f0bd438e7

[sobitneupane]

@sobitneupane sorry! Can you please apply for the job so we can issue payment: https://www.upwork.com/jobs/~018897a01f0bd438e7

Applied.

[NicMendonca]

paid!