-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD payment 01-30-23] Remove loading screen logs #8367
Comments
Still holding |
Not really used, though I think we can revisit this in a month after we complete the api refactors to see if it provides any additional debugging assistance |
Same as above, logs haven't been useful for now |
Same |
I think this is fine to remove, we haven't used it - will get a PR up later |
Haven't done this, not really a priority |
Same as above, here is the PR #8347 |
Job added to Upwork: https://www.upwork.com/jobs/~012d8e2262399c8ead |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr ( |
Triggered auto assignment to @sakluger ( |
This comment was marked as off-topic.
This comment was marked as off-topic.
Adding 'Internal' and BugZero so we can make sure to pay out @mananjadhav for reviewing the PR here #14374 Not yet on production and so will still have to wait for that |
Just sent an offer to @mananjadhav in Upwork! |
Thanks @sakluger. Accepted |
7 day regression wait is done 01-30-23 This is a pretty small bug so I don't imagine any problems though 👍 |
This comment was marked as off-topic.
This comment was marked as off-topic.
@mananjadhav There doesn't seem to be anything actionable here, payment date will be 01-30-23. Sorry if I didn't make that clear in my last comment |
Sorry my bad @thienlnam @sakluger. I read this as Jan 23, instead of 2023. |
No problem! 😄 |
@sakluger Quick bump on the payout. |
Sorry for the delay and thanks for the bump. I paid through Upwork, thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
As part of #7424, we added logs to help identify locations where slow spinners appear. Now that we've resolve the issue of slow spinners, should we remove the logs or have they been helpful in debugging other loading screen issues?
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: