Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD payment 01-30-23] Remove loading screen logs #8367

Closed
thienlnam opened this issue Mar 30, 2022 · 21 comments
Closed

[HOLD payment 01-30-23] Remove loading screen logs #8367

thienlnam opened this issue Mar 30, 2022 · 21 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Mar 30, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


As part of #7424, we added logs to help identify locations where slow spinners appear. Now that we've resolve the issue of slow spinners, should we remove the logs or have they been helpful in debugging other loading screen issues?

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012d8e2262399c8ead
  • Upwork Job ID: 1616501995085864960
  • Last Price Increase: 2023-01-20
@thienlnam
Copy link
Contributor Author

Still holding

@melvin-bot melvin-bot bot removed the Overdue label May 2, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 2, 2022
@thienlnam
Copy link
Contributor Author

Not really used, though I think we can revisit this in a month after we complete the api refactors to see if it provides any additional debugging assistance

@melvin-bot melvin-bot bot removed the Overdue label Jun 2, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 4, 2022
@thienlnam
Copy link
Contributor Author

Same as above, logs haven't been useful for now

@melvin-bot melvin-bot bot removed the Overdue label Jul 5, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 8, 2022
@thienlnam
Copy link
Contributor Author

Same

@melvin-bot melvin-bot bot removed the Overdue label Aug 9, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 12, 2022
@thienlnam
Copy link
Contributor Author

I think this is fine to remove, we haven't used it - will get a PR up later

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2022
@puneetlath puneetlath added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 19, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 21, 2022
@thienlnam thienlnam changed the title [HOLD 7424] Remove loading screen logs Remove loading screen logs Oct 21, 2022
@thienlnam thienlnam added Weekly KSv2 and removed Monthly KSv2 labels Oct 21, 2022
@melvin-bot melvin-bot bot removed the Overdue label Oct 21, 2022
@melvin-bot melvin-bot bot added the Overdue label Oct 31, 2022
@puneetlath puneetlath added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 2, 2022
@thienlnam
Copy link
Contributor Author

Haven't done this, not really a priority

@melvin-bot melvin-bot bot removed the Overdue label Nov 3, 2022
@thienlnam thienlnam removed the Weekly KSv2 label Nov 3, 2022
@thienlnam
Copy link
Contributor Author

Same as above, here is the PR #8347

@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2022
@melvin-bot melvin-bot bot added the Overdue label Jan 13, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Jan 17, 2023
@thienlnam thienlnam added the Internal Requires API changes or must be handled by Expensify staff label Jan 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~012d8e2262399c8ead

@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

@thienlnam thienlnam assigned mananjadhav and unassigned mollfpr Jan 20, 2023
@thienlnam thienlnam added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 20, 2023

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 labels Jan 20, 2023
@melvin-bot

This comment was marked as off-topic.

@thienlnam
Copy link
Contributor Author

thienlnam commented Jan 20, 2023

Adding 'Internal' and BugZero so we can make sure to pay out @mananjadhav for reviewing the PR here #14374

Not yet on production and so will still have to wait for that

@sakluger
Copy link
Contributor

Just sent an offer to @mananjadhav in Upwork!

@mananjadhav
Copy link
Collaborator

Thanks @sakluger. Accepted

@thienlnam thienlnam changed the title Remove loading screen logs [HOLD payment 01-30-23] Remove loading screen logs Jan 24, 2023
@thienlnam
Copy link
Contributor Author

7 day regression wait is done 01-30-23

This is a pretty small bug so I don't imagine any problems though 👍

@mananjadhav

This comment was marked as off-topic.

@thienlnam
Copy link
Contributor Author

@mananjadhav There doesn't seem to be anything actionable here, payment date will be 01-30-23. Sorry if I didn't make that clear in my last comment

@mananjadhav
Copy link
Collaborator

Sorry my bad @thienlnam @sakluger. I read this as Jan 23, instead of 2023.

@thienlnam
Copy link
Contributor Author

No problem! 😄

@mananjadhav
Copy link
Collaborator

@sakluger Quick bump on the payout.

@sakluger
Copy link
Contributor

Sorry for the delay and thanks for the bump. I paid through Upwork, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants