IOS - App is freezing after tap on "Make default payment method"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch App and login with expensifail account
2. Go to the Payments page.
3. Click any existing payment method to set it to default
4. Click set default

Expected Result:

Payment should be set as default payment method

Actual Result:

App is freezing after tap on "Make default payment method"

Workaround:

Unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.39.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5465487_RPReplay_Final1645571874.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

Issue was found when execute the PR: #7782

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[TomatoToaster]

So this looks like it had to do with the password input not rendering correctly after selecting the payment method

@parasharrajat your PR fixed this perfectly so I'm going to add this to the list of fixed issues in your PR and close this issue.

[mountiny]

@TomatoToaster The QA seems to reproduce this issue on production and staging still. Relevant comments here and here.

[mountiny]

not overdue

[parasharrajat]

Wrong issue. Sorry.

[TomatoToaster]

As far as I can tell, this seems to be an issue where the passover prompt doesn't end up showing up after being clicked here:

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Lines 316 to 324 in d05c56e

	<TouchableOpacity
	onPress={() => {
	this.setState({
	shouldShowPasswordPrompt: true,
	shouldShowDefaultDeleteMenu: false,
	passwordButtonText: this.props.translate('paymentsPage.setDefaultConfirmation'),
	});
	}}
	style={[styles.button, styles.alignSelfCenter, styles.w100]}

There must be another issue causing this if this is only happening on iOS but I'm not sure why this is happening. I think this can be externally solved.

[MelvinBot]

Triggered auto assignment to @jboniface (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[parasharrajat]

This is a duplicate of #7768. The same solution will fix both.

[mountiny]

I thought they are very similar, I will assign this to myself then, but I wont close it yet and wait to see if this wont be reproducible on iOS.

@jboniface sorry for the ping.

[melvin-bot]

This issue has not been updated in over 15 days. @mountiny eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

Closing as the linked issue seems to be solved.