[HOLD for payment 2022-03-17] Feature Request: Data is getting written to Onyx after logout - reported by @kidroca

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Be logged out
2. Be on a slow network (see "Slow 3g" on the opened dev tools)
3. Log to an account with some existing conversations
4. Quickly log out the second you see LHN loaded (You can verify in dev tools that requests are still pending)
5. Now log in with another account
6. Observe issues - LHN has conversations from the previous account, a lot of unread messages

Expected Result:

We can abort requests to save bandwidth and prevent other issues

Actual Result:

Some times we know there are requests bound to fail or requests for whom we're no longer interested in the results.

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.31-0
Reproducible in staging?:
Reproducible in production?:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

New.Expensify.-.Google.Chrome.2022-01-25.21-05-00.mp4

Upwork URL: https://www.upwork.com/jobs/~01bcb9c814f48af12c
Issue reported by: @kidroca
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1642188186471800

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[MelvinBot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alex-mechler]

Tagging a couple people who were involved in the discussions around this and sending it external

cc @iwiznia @marcaaron

[MelvinBot]

Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[kidroca]

Related to:

• Chats from another account are shown in my new account on NewDot #5034
• Onyx.clear() does not fully clear storage if data is in the process of being written #2642

[parasharrajat]

Yeah, this is happening.

[dylanexpensify]

Working on getting posted!

[dylanexpensify]

Internal: https://www.upwork.com/ab/applicants/1488091707711356928/job-details
External: https://www.upwork.com/jobs/~01bcb9c814f48af12c

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[MelvinBot]

Triggered auto assignment to @tgolen (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

Excited to review proposals on this one!

[parasharrajat]

A solution could be:

1. Make xhr method return cancellable promise.

   App/src/libs/HttpUtils.js

   Line 38 in 2cdb7c3

   function xhr(command, data, type = CONST.NETWORK.METHOD.POST, shouldUseSecure = false) {

   via

   App/src/libs/MakeCancellablePromise.js

   Line 8 in 2cdb7c3

   export default function makeCancellablePromise(promise) {

   .

2. Track all the cancel callbacks from this call.

   App/src/libs/Network.js

   Line 228 in 2cdb7c3

   HttpUtils.xhr(queuedRequest.command, finalParameters, queuedRequest.type, queuedRequest.shouldUseSecure)

3. Add a method in Network.js to call all of that cancel callbacks and add that to

   App/src/libs/actions/Session/index.js

   Line 373 in 2cdb7c3

   function cleanupSession() {

   .

Method 2

1. Add a new Flag to the Network.js something like blockinFlightRequests: Boolean.
2. Create a callback to set that flag to true and call that callback to

   App/src/libs/actions/Session/index.js

   Line 373 in 2cdb7c3

   function cleanupSession() {

   ..
3. Update

   App/src/libs/Network.js

   Line 228 in 2cdb7c3

   HttpUtils.xhr(queuedRequest.command, finalParameters, queuedRequest.type, queuedRequest.shouldUseSecure)

   call so that it checks that flag and don't execute the handlers for API call.
   

   App/src/libs/Network.js

   Lines 228 to 235 in 2cdb7c3

   	HttpUtils.xhr(queuedRequest.command, finalParameters, queuedRequest.type, queuedRequest.shouldUseSecure)
   	.then(response => onResponse(queuedRequest, response))
   	.catch((error) => {
   	// When the request did not reach its destination add it back the queue to be retried
   	const shouldRetry = lodashGet(queuedRequest, 'data.shouldRetry');
   	if (shouldRetry) {
   	networkRequestQueue.push(queuedRequest);
   	return;

Pseudocode

            .then(response => blockinFlightRequests? undefined: onResponse(queuedRequest, response))
            .catch((error) => {
 				if(blockinFlightRequests) {
					return;
				}
                // When the request did not reach its destination add it back the queue to be retried
                const shouldRetry = lodashGet(queuedRequest, 'data.shouldRetry');
                if (shouldRetry) {
                    networkRequestQueue.push(queuedRequest);
                    return;
                }

                onError(queuedRequest, error);
            });

But it imposes a challenge for us When should we set the blockinFlightRequests flag back to false. I don't know have any idea for now.

[tgolen]

Not overdue

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.41-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Cancel pending requests when signing out #7805

If no regressions arise, payment will be issued on 2022-03-17. 🎊

[MelvinBot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[dylanexpensify]

Reassigning as I'm OOO next week! Thanks Tom for handling the payment if no regressions! 🙇

[trjExpensify]

@kidroca - paid. @rushatgabhane waiting for you to accept the offer for C+.

[rushatgabhane]

@trjExpensify accepted, thanks!

[trjExpensify]

Cool, settled!

[kidroca]

@trjExpensify
I thought I was getting paid for reporting and fixing the issues
It seems I was only paid for fixing

[trjExpensify]

You thought correctly! Sorry about that, I just settled the contract that was in place.

So I sent you a bonus for an additional $250. Got an error message in Upwork saying there was a problem with the account. Did it again and now it looks like I've paid you an extra $250. Can you double check that? 😅

[kidroca]

So I sent you a bonus for an additional $250. Got an error message in Upwork saying there was a problem with the account. Did it again and now it looks like I've paid you an extra $250. Can you double check that? 😅

Just checked, indeed I've been paid twice for reporting
I've issued a refund for $250 reverting one of the bonus payments

[trjExpensify]

Perfect, just got the email for the refund. Going to close this one out again, thanks!