Deploy Checklist: New Expensify 2025-03-04

[github-actions]

Release Version: 9.1.9-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix:blank page appears in validate code form page #55588
• fix: Workspace - The new WS names appear in English when Spanish is set up. #55850
• play success sound on report approval #56455
• Initial implementation of the Side Pane #56490
• fix: remove flashing effect when opening a report #56523
• Clickable emoji for expense task #56602
• [HybridApp] Receive structured initialProperties (not as url) and improve url handling #56698
• Create configure-per-diem #56776
• [No QA] Update Managing-Workspace-Members.md #56794
• Fix can't mark one-expense report as unread #56893
• [HybridApp] Adjust RCTBootSplash.mm to HybridApp requirements #56953
• When disabling workflows, set autoreporting back to "immediately" #57147
• Fix PDF files shadow #57185
• fix: navigate back to thread after clicking on header #57188
• fix: System message when changing submission frequency to monthly, not translated to Spanish #57200
• fix: Duplicate paid adoption events are logged #57227
• Fix logo doesn't change color in dark mode on safari #57268
• [FIX] Android - Workspace -"You appear to be offline" displayed behind keyboard on currency change #57339
• fix: Missing bookmark icon for saved #57368
• Fix - Rules - Members can change report name after Preventing members from changing report #57392
• Fix - Company cards - QBO: user stays on Export tab when click back arrow #57394
• Fix: Android - Tax - After entering zero dot cursor thickness is changed #57444
• fix: Rename search page is reopened after saving #57449
• fix hover lost when the element is blurred #57451
• [No QA] Implement report primary action getter #57475
• [No QA][HybridApp] Fix is-hybrid-app.sh script #57484
• fix: search page cannot be dismissed by swiping to the right #57516
• Shows cancel payment instead of unapprove when the expense is paid but waiting for bank account #57524
• Fix: The Next button moves up when user goes offline #57534
• Don't render expand icon when not needed #57538
• Workspace - Background changes when reloading in Downgrade or Upgrade workspace page #57540
• fix: incorrect navigate when dismissing tax picker #57555
• fix - Held expense - Back button closes RHP when accessing Hold reason page from report details RHP #57565
• Fix - iOS Reports - Selection mode persists in Reports after entering selection mode in Categories #57636
• remove auto-pinning of chats in optimistic data #57638
• fix: incorrect invite message is shown in lhn #57659
• Fix closing modal on PDF attachment load error #57664
• [No QA] Remove Spotnana's scheduled maintenance modal #57779
• [NO QA] Update action runners to 24.04 #57788
• [CP STAGING] Add defensive check for signupQualifier in OnboardingFlow #57794
• [CP Staging] Fix: Scroll Issue on Reports Page, side pane appearing after language change #57831
• [CP STAGING] fix: Attachments-Swiping to the left through attachment #57856
• [CP Staging] Revert "Merge pull request #56602 from Amoralchik/clickable-emoji-for… #57890

Internal QA:

• [No QA] build hybrid apps from Build and deploy apps for testing workflows #56769 - @Julesssss

Deploy Blockers:

• iOS app crashes with new build 9.1.9-0 #57795
• LHN - FAB does not close when clicking FAB button again when FAB is opened #57797
• Help panel - Help RHP does not close when clicking outside RHP or with ESC key #57798
• mweb - Help panel - Help icon is missing on mweb #57799
• Help Panel - Tooltip is shown over Help RHP #57805
• Help panel - Help panel opens behind RHP on edit photo and view attachment page #57806
• Report- Report view shakes after returning from Reports & bottom tab moves after saving search #57807
• Help panel - Get assistance and Help buttons have the same icon on invite member RHP #57808
• Help Panel - When opening other RHPs, the Help RHP stays above them #57810
• [$250] Help panel - Help panel animates strangely when workspace switcher is closed #57811
• Help panel - Magic code panel opens on the wrong panel when help panel is opened #57812
• Help panel - 3-dot menu opens on help panel instead of below 3-dot button #57813
• Help panel - Share code appears zoomed in briefly when opening share RHP with help panel #57815
• [$250] Subscription - User remains on Subscription page when tapping browser back button #57817
• Android Hybrid-Attachment- It is hard to scroll the pdf file #57823
• iOS Hybrid - Attachments-Swiping to the left through attachment previews navigates back to the chat #57825
• [$250] mWeb - Reports - Last message on "Chats" is cutted off and can´t be fully read #57827
• IOU - Help modal opens Missing page for route #57832
• Help panel - RHP does not appear and disappear smoothly when help panel is opened #57833
• Hold - Hold page lead to detail page when hold expense #57835
• [$250] Help panel - Unable to save expense description edit when help panel is opened #57837
• Android - Help panel - Section header is split into two lines on narrow display #57838
• iOS&Android - Help panel - Keyboard does not dismiss when help panel is opened #57839
• Android - Help panel - Incorrect navigation with device back button when help panel is opened #57840
• iOS - Help button - Spacing between help button and search button is bigger in Inbox #57854
• iOS - Help panel - Unable to swipe right to close the help page #57855
• [$250] Temporary login is seen as unvalidated login when signing in #57869
• App crashes with new build 9.1.9-6 #57909
• Hybrid Android - Launch - App crashes when launched. #57912

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Julesssss]

Checking off internal QA here

[mvtglobally]

@Julesssss @puneetlath IOS is crashing on launch. Logging issue. Did IOS build deploy?

[Julesssss]

Yeah I see that 9.1.9.0 was pushed to TestFlight and that's the latest version.

I can reproduce the crash on launch when authenticated, but if I'm signed out then I land at the authentication page.

[puneetlath]

I can repro as well. Yikes. Let’s go ahead and create a blocker for it and we can have the team start looking into it.

[mvtglobally]

@puneetlath #57795 created

[francoisl]

Demoting #57798, feature is not visible to customers yet (cc @MonilBhavsar)

[AndrewGable]

iOS is fixed on latest staging version

[francoisl]

Hi @mvtglobally and team, if you see any other bug with the help pane, feel free to open an issue, but no need to make it a blocker. You can add a link to your issue in this tracking issue instead. Thanks!

[izarutskaya]

Regression is at 83% completed.

Blockers:
#57797
#57815
#57817
#57825
#57827

[shawnborton]

Not sure what the process is for blockers but note that this PR caused a blocker. The fix is up here and would need to be CPed, cc @blazejkustra

[lakchote]

Demoted #57825, see why here, and posted a comment about the likely PR that has caused this.

[mjasikowski]

demoted #56490

[cristipaval]

demoted #57832

[izarutskaya]

Regression is at 92% completed.

Unchecked PRs:
#56455 - failing with original bug ID #56455 (comment)
#56490 - found issues #56490 (comment)

DB:
#57797
#57815
#57817
#57833
#57835
#57837
#57838
#57839
#57840

[grgia]

demoted #57835

[puneetlath]

Checked off all the help pane ones since that feature is behind a beta.

[amyevans]

Demoted #57855

[mvtglobally]

Informed the team not to add Blocker label for Help panel for now.

[Beamanator]

demoted #57817

[mvtglobally]

Regression is completed.

Unchecked PRs:
#56455 - failing with original bug ID #56455 (comment)
#57227 - Pending validation
#57659 - failing with #57853. Repro in PROD. checking off

DB:
#57797
#57823

[mvtglobally]

PR #57227 is blocked by #57883. Ok to check off?

[puneetlath]

Yes, I'll check it off @mvtglobally

[puneetlath]

One fresh crash but it was fixed via CP. No spiking crashes from previous release.

[mvtglobally]

We are seeing a crash on IOS 9.1.9-6 . Logging a new issue in a sec,

[mvtglobally]

Logged 2 issues which are probably same root cause. Only reason 2, as Android was crashing on previous build and IOs wasn't, so not sure if root is same or different.

#57912
#57909

[Julesssss]

Checked off #57912 as a dupe of #57909 which is being handled here.