[Due for payment 2025-03-17] [Due for payment 2025-03-13] [$250] iOS - TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined

[Julesssss]

Problem

This crash has recently blown up on iOS --I don't see any crashes increasing on Android, though this could be the case.

We don't have reproducible steps

Fatal Exception: facebook::jsi::JSError
Exception in HostFunction: Unhandled JS Exception: TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined

Stack Trace:
    at getOnboardingInitialPath (401791:32)
    at startOnboardingFlow         (401779:85)
    at anonymous                  (540755:66)
    at processNext                (70806:18)
    at _processUpdate             (70731:30)
    at anonymous                  (40510:22)

Solution:

Investigate stack trace

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897037934087402019
• Upwork Job ID: 1897037934087402019
• Last Price Increase: 2025-03-04

Issue Owner

Current Issue Owner: @johncschuster

[Julesssss]

• Shared with expert contributors for triage
• Shared with deployers to figure out how this slipped through

[Shahidullah-Muffakir]

As mentioned in the Stack trace it is coming from here:

App/src/libs/actions/Welcome/OnboardingFlow.ts

Line 56 in bf1ac4a

const isVsb = onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

and

App/src/libs/actions/Welcome/OnboardingFlow.ts

Line 68 in bf1ac4a

const isIndividual = onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.INDIVIDUAL;

Because null check is not added for signupQualifier.

like it is added here:

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Line 60 in bf1ac4a

const isVsb = onboardingValues && 'signupQualifier' in onboardingValues && onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

[Julesssss]

Hey @Shahidullah-Muffakir, thanks would you like to be assigned to resolving this? We don't have reproducable steps for verification but it should be an easy to resolve and verify in the crash logs

[Shahidullah-Muffakir]

Hey @Shahidullah-Muffakir, thanks would you like to be assigned to resolving this? We don't have reproducable steps for verification but it should be an easy to resolve and verify in the crash logs

Sure, I can create a quick PR, the changes seems straight forward.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897037934087402019

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[Julesssss]

Assigning @Shahidullah-Muffakir. For tests in the PR can you just add a couple of cases related to the onboarding flow. Something like:

• Create new account > company > set company size

[melvin-bot]

📣 @Shahidullah-Muffakir You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Julesssss]

By happy coincidence @trjExpensify can reproduce this! He's going to verify on the AdHoc build

[trjExpensify]

Confirmed ✅

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.9-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP STAGING] Add defensive check for signupQualifier in OnboardingFlow #57794

If no regressions arise, payment will be issued on 2025-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

[melvin-bot]

@Julesssss @johncschuster @Shahidullah-Muffakir The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[johncschuster]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[johncschuster]

@Shahidullah-Muffakir can you please post your Upwork profile? I'll need that so I can invite you to the job. Thanks!

[Shahidullah-Muffakir]

Sure, here’s my Upwork profile:https://www.upwork.com/freelancers/~01a4e04674db05abb1, Thanks.

[johncschuster]

@Shahidullah-Muffakir Thank you! Please accept this offer!

[Shahidullah-Muffakir]

@Shahidullah-Muffakir Thank you! Please accept this offer!

Offer Accepted, Thanks.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.10-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP STAGING] Add defensive check for signupQualifier in OnboardingFlow #57794

If no regressions arise, payment will be issued on 2025-03-17. 🎊

For reference, here are some details about the assignees on this issue:

• @Shahidullah-Muffakir requires payment (Needs manual offer from BZ)

[melvin-bot]

@Julesssss @johncschuster @Shahidullah-Muffakir The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]